Skip Menu |

This queue is for tickets about the Font-TTF CPAN distribution.

Report information
The Basics
Id: 106562
Status: resolved
Priority: 0/
Queue: Font-TTF

People
Owner: bhallissy [...] cpan.org
Requestors: jv [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.05
Fixed in: 1.06



Some fonts issue a lot of warnings similar to: Use of uninitialized value $_[1] in read at /usr/lib64/perl5/IO/Handle.pm line 463. Suggested fix: --- /home/jv/lib/perl5/Font/TTF/Glyph.pm~ 2015-08-20 16:25:49.656873029 +0200 +++ /home/jv/lib/perl5/Font/TTF/Glyph.pm 2015-08-20 16:28:25.029853617 +0200 @@ -262,13 +262,13 @@ { my ($self) = @_; my ($fh) = $self->{' INFILE'}; - my ($dat); + my $dat = ""; return $self if (defined $self->{' read'} && $self->{' read'} > 0); $self->{' read'} = 1; $fh->seek($self->{' LOC'} + $self->{' BASE'}, 0); - $fh->read($self->{' DAT'}, $self->{' LEN'}); - TTF_Read_Fields($self, $self->{' DAT'}, \%fields); + $fh->read($dat, $self->{' LEN'}); + TTF_Read_Fields($self, $self->{' DAT'} = $dat, \%fields); $self; }
For testing purposes, can you point me to an available font that triggers this?
RT-Send-CC: jv [...] cpan.org
Trying again... cc'd jv this time... On Tue Sep 01 23:04:16 2015, BHALLISSY wrote: Show quoted text
> For testing purposes, can you point me to an available font that > triggers this?
Show quoted text
> > For testing purposes, can you point me to an available font that > > triggers this?
The attached zip contains DejaVuSansMono and a test program. HTH.
Subject: tt.zip
Download tt.zip
application/zip 175.6k

Message body not shown because it is not plain text.

Ah, many thanks. That does help. I've committed most of your suggestion to the repo [now on github]. I didn't initialize $dat as that isn't needed. On Wed Sep 09 02:28:12 2015, JV wrote: Show quoted text
> The attached zip contains DejaVuSansMono and a test program. > > HTH.
fixed