Skip Menu |

This queue is for tickets about the AnyEvent-RabbitMQ CPAN distribution.

Report information
The Basics
Id: 106550
Status: resolved
Priority: 0/
Queue: AnyEvent-RabbitMQ
People
Owner: DLAMBLEY [...] cpan.org
Requestors: julio [...] hawaii.edu
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.20_01

History Show all quoted text
  Wed Aug 19 21:58:31 2015 julio [...] hawaii.edu - Ticket created
Subject: Support no_ack for get()
Date: Wed, 19 Aug 2015 15:58:21 -1000
To: bug-AnyEvent-RabbitMQ [...] rt.cpan.org
From: Julio Polo <julio [...] hawaii.edu>
Could you support passing the value of no_ack to the get method? Only two lines need to change for this to happen: *** 566,577 **** my $self = shift; my ($cb, $failure_cb, %args) = $self->_delete_cbs(@_); return $self if !$self->_check_open($failure_cb); $self->{connection}->_push_write_and_read( 'Basic::Get', { ! no_ack => 1, %args, # queue ticket => 0, }, --- 566,579 ---- my $self = shift; my ($cb, $failure_cb, %args) = $self->_delete_cbs(@_); + my $no_ack = delete $args{no_ack} // 1; + return $self if !$self->_check_open($failure_cb); $self->{connection}->_push_write_and_read( 'Basic::Get', { ! no_ack => $no_ack, %args, # queue ticket => 0, }, Julio Polo University of Hawaii
  Fri May 22 14:11:24 2020 DLAMBLEY [...] cpan.org - Correspondence added
On Wed Aug 19 21:58:31 2015, julio@hawaii.edu wrote: Show quoted text
> Could you support passing the value of no_ack to the get method? Only two > lines need to change for this to happen: > > *** 566,577 **** > my $self = shift; > my ($cb, $failure_cb, %args) = $self->_delete_cbs(@_); > > return $self if !$self->_check_open($failure_cb); > > $self->{connection}->_push_write_and_read( > 'Basic::Get', > { > ! no_ack => 1, > %args, # queue > ticket => 0, > }, > --- 566,579 ---- > my $self = shift; > my ($cb, $failure_cb, %args) = $self->_delete_cbs(@_); > > + my $no_ack = delete $args{no_ack} // 1; > + > return $self if !$self->_check_open($failure_cb); > > $self->{connection}->_push_write_and_read( > 'Basic::Get', > { > ! no_ack => $no_ack, > %args, # queue > ticket => 0, > }, > > Julio Polo > University of Hawaii
Hello, Thank you for your patch. Are you still using the module? I have made a pull request for your change, https://github.com/bobtfish/AnyEvent-RabbitMQ/pull/30 I'll merge and release some time soon. All the best, Dave
  Fri May 22 14:11:25 2020 The RT System itself - Status changed from 'new' to 'open'
  Fri May 22 14:11:25 2020 DLAMBLEY [...] cpan.org - Taken
  Fri May 29 21:11:42 2020 julio [...] hawaii.edu - Correspondence added
Subject: Re: [rt.cpan.org #106550] Support no_ack for get()
Date: Fri, 29 May 2020 15:11:20 -1000
To: bug-AnyEvent-RabbitMQ [...] rt.cpan.org
From: Julio Polo <julio [...] hawaii.edu>
Thank you! Yes, we're still using it, although we would like to move much of our code to Python. -julio On Fri, May 22, 2020 at 8:11 AM Dave Lambley via RT < bug-AnyEvent-RabbitMQ@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=106550 > > > On Wed Aug 19 21:58:31 2015, julio@hawaii.edu wrote:
> > Could you support passing the value of no_ack to the get method? Only
> two
> > lines need to change for this to happen: > > > > *** 566,577 **** > > my $self = shift; > > my ($cb, $failure_cb, %args) = $self->_delete_cbs(@_); > > > > return $self if !$self->_check_open($failure_cb); > > > > $self->{connection}->_push_write_and_read( > > 'Basic::Get', > > { > > ! no_ack => 1, > > %args, # queue > > ticket => 0, > > }, > > --- 566,579 ---- > > my $self = shift; > > my ($cb, $failure_cb, %args) = $self->_delete_cbs(@_); > > > > + my $no_ack = delete $args{no_ack} // 1; > > + > > return $self if !$self->_check_open($failure_cb); > > > > $self->{connection}->_push_write_and_read( > > 'Basic::Get', > > { > > ! no_ack => $no_ack, > > %args, # queue > > ticket => 0, > > }, > > > > Julio Polo > > University of Hawaii
> > Hello, > > Thank you for your patch. Are you still using the module? I have made a > pull request for your change, > https://github.com/bobtfish/AnyEvent-RabbitMQ/pull/30 > > I'll merge and release some time soon. > > All the best, > Dave >
  Sat May 30 04:33:29 2020 DLAMBLEY [...] cpan.org - Correspondence added
On Fri May 29 21:11:42 2020, julio@hawaii.edu wrote: Show quoted text
> Thank you! Yes, we're still using it, although we would like to move much > of our code to Python.
I released this in a dev release, 0.20_01, I'll release properly later today. Dave
  Sat May 30 04:33:31 2020 DLAMBLEY [...] cpan.org - Fixed in 1.20_01 added
  Sat May 30 18:46:47 2020 DLAMBLEY [...] cpan.org - Status changed from 'open' to 'resolved'