| Subject: | Some Path.t fixes for VMS plus other failures |
| Date: | Fri, 07 Aug 2015 15:54:48 -0500 |
| To: | bugs-File-Path [...] rt.cpan.org |
| From: | "Craig A. Berry" <craigberry [...] mac.com> |
There were several new test failures when 2.11 came into blead. The attached fixes those.
As I was testing this, I ran against current head from github and found that there are a bunch of additional failures in the verbose mode tests. These tests were exposed by the removal of the requirement for Test::Output so had probably never been run before on VMS.
There are two basic problems I can see right off, detailed output below.
In verbose mode, mkdir reports what it’s working on in Unix format on VMS, whereas the test has constructed expectations from catdir, which always returns a path in native format.
In safe mode, rmtree reports "skipped" when it can’t remove a directory without changing permissions. The difference on VMS is that the default protection for directories does not allow deletion without explicitly changing protection, but the test assumes that directories can always be deleted without doing so.
ok 96 # skip Mode of 0 means assume user defaults on VMS
not ok 97 - mkpath verbose (old style 1)
# Failed test 'mkpath verbose (old style 1)'
# at t/Path.t line 487.
# got: 'mkdir test-55c51426-437-17bae/output
# mkdir test-55c51426-437-17bae/output/A/
# '
# expected: 'mkdir [.test-55c51426-437-17bae.output]
# mkdir [.test-55c51426-437-17bae.output.A]
# '
not ok 98 - mkpath verbose (old style 2)
# Failed test 'mkpath verbose (old style 2)'
# at t/Path.t line 492.
# got: 'mkdir test-55c51426-437-17bae/output/B/
# '
# expected: 'mkdir [.test-55c51426-437-17bae.output.B]
# '
not ok 99 - rmtree verbose (old style)
# Failed test 'rmtree verbose (old style)'
# at t/Path.t line 497.
# got: 'skipped [.test-55c51426-437-17bae.output.A]
# skipped [.test-55c51426-437-17bae.output.B]
# '
# expected: 'rmdir [.test-55c51426-437-17bae.output.A]
# rmdir [.test-55c51426-437-17bae.output.B]
# '
not ok 100 - mkpath verbose (new style 1)
# Failed test 'mkpath verbose (new style 1)'
# at t/Path.t line 502.
# got: ''
# expected: 'mkdir [.test-55c51426-437-17bae.output.A]
# '
not ok 101 - mkpath verbose (new style 2)
# Failed test 'mkpath verbose (new style 2)'
# at t/Path.t line 507.
# got: ''
# expected: 'mkdir [.test-55c51426-437-17bae.output.B]
# '
not ok 102 - again: rmtree verbose (old style)
# Failed test 'again: rmtree verbose (old style)'
# at t/Path.t line 512.
# got: 'skipped [.test-55c51426-437-17bae.output.A]
# skipped [.test-55c51426-437-17bae.output.B]
# '
# expected: 'rmdir [.test-55c51426-437-17bae.output.A]
# rmdir [.test-55c51426-437-17bae.output.B]
# '
not ok 103 - make_path verbose with final hashref
# Failed test 'make_path verbose with final hashref'
# at t/Path.t line 517.
# got: ''
# expected: 'mkdir [.test-55c51426-437-17bae.output.A]
# mkdir [.test-55c51426-437-17bae.output.B]
# '
ok 104 - remove_tree verbose with final hashref
Show quoted text
________________________________________
Craig A. Berry
mailto:craigberry@mac.com
"... getting out of a sonnet is much more
difficult than getting in."
Brad Leithauser
Message body is not shown because sender requested not to inline it.