Bug #106250 for Net-SNTP-Client: Failed tests if there's no connection

Tue Aug 04 13:27:32 2015 steveb [...] cpan.org - Ticket created

Subject:	Failed tests if there's no connection
Date:	Tue, 4 Aug 2015 11:27:18 -0600
To:	bug-Net-SNTP-Client [...] rt.cpan.org
From:	Steve Bertrand <steve.bertrand [...] gmail.com>

Attached is a patch that fixes the following test failures: http://www.cpantesters.org/cpan/report/bb918aaa-3aac-11e5-a85a-e28fcaadd3a7 They are caused when a server is running the tests can't connect to the host. You can repro this by putting erroneous characters into the hostname in the %hashInputModuleTest thereby making it an invalid name (or simply be on a host behind a firewall not allowing outbound connections, or unplug your network connection). The patch creates a SKIP block around the two tests that fail with no connection, and skips them if the call returns an $error. You might consider adding tests for connectivity early on, and put a disclaimer that a valid network connection to a specified server is a must. Cheers, Steve (aka. stevieb)

Message body is not shown because sender requested not to inline it.

Thu Aug 06 16:47:21 2015 thanos.egw [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #106250] Failed tests if there's no connection
Date:	Thu, 6 Aug 2015 23:46:57 +0300
To:	bug-Net-SNTP-Client [...] rt.cpan.org
From:	Athanasios Garyfalos <thanos.egw [...] gmail.com>

Hello stevieb <http://www.perlmonks.org/?node=stevieb>, Thanks for the tip, although that I have added a timeout option on my script I was still getting this error. I just pushed an updated version 0.16 it will be updated on CPAN also. Thank you for your time and effort trying to assist me. Best Regards, Athanasios Garyfalos (aka thanos1983) On 4 August 2015 at 20:27, Steve Bertrand via RT < bug-Net-SNTP-Client@rt.cpan.org> wrote: Show quoted text

> Tue Aug 04 13:27:32 2015: Request 106250 was acted upon. > Transaction: Ticket created by steveb > Queue: Net-SNTP-Client > Subject: Failed tests if there's no connection > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: steve.bertrand@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=106250 > > > > Attached is a patch that fixes the following test failures: > http://www.cpantesters.org/cpan/report/bb918aaa-3aac-11e5-a85a-e28fcaadd3a7 > > They are caused when a server is running the tests can't connect to the > host. You can repro this by putting erroneous characters into the hostname > in the %hashInputModuleTest thereby making it an invalid name (or simply be > on a host behind a firewall not allowing outbound connections, or unplug > your network connection). > > The patch creates a SKIP block around the two tests that fail with no > connection, and skips them if the call returns an $error. > > You might consider adding tests for connectivity early on, and put a > disclaimer that a valid network connection to a specified server is a must. > > Cheers, > > Steve (aka. stevieb) > >

-- Athanasios Gayfalos PGDip. Wireless Sensor Networks Beng. Electrical and Electronics Engineering Msc. Software Development on Telecommunication Networks

Thu Aug 06 16:47:21 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Sep 22 12:04:03 2015 garyfalos [...] cpan.org - Taken

Fri Oct 09 07:09:43 2015 garyfalos [...] cpan.org - Status changed from 'open' to 'resolved'