Bug #106130 for Tree-DAG_Node: Tree::DAG_Node mucks with STDIN/STDOUT

Tue Jul 28 12:27:17 2015 schmorp [...] schmorp.de - Ticket created

Subject:	Tree::DAG_Node mucks with STDIN/STDOUT
Date:	Tue, 28 Jul 2015 18:27:04 +0200
To:	bug-Tree-DAG_Node [...] rt.cpan.org
From:	Marc Lehmann <schmorp [...] schmorp.de>

Hi! We sometimes have crashes when loading Tree::DAG_Node in one of our servers. The reason turned out to be Tree::DAG_Node mucking with STDIN/STDOUT/STDERR in rather unexpected ways: use open qw(:std :utf8); # Undeclared streams in UTF-8. This caused data corruption because it ignores the user/program-configured encoding and enforces utf-8. For streams that do not support this, you get a crash on loading, for others you get silent data corruption. I suggest simply dropping this line - modules should not silently change STDIN/OUT/ERR, especially not on loading, when they ahve nothing whatsoever to do with these handles. -- The choice of a Deliantra, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / schmorp@schmorp.de -=====/_/_//_/\_,_/ /_/\_\

Tue Jul 28 12:44:58 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-07-28 12:27:17, schmorp@schmorp.de wrote: Show quoted text

> Hi! > > We sometimes have crashes when loading Tree::DAG_Node in one of our > servers. > > The reason turned out to be Tree::DAG_Node mucking with > STDIN/STDOUT/STDERR in rather unexpected ways: > > use open qw(:std :utf8); # Undeclared streams in UTF-8. > > This caused data corruption because it ignores the user/program-configured > encoding and enforces utf-8. For streams that do not support this, you get a > crash on loading, for others you get silent data corruption. > > I suggest simply dropping this line - modules should not silently > change STDIN/OUT/ERR, especially not on loading, when they ahve nothing > whatsoever to do with these handles. >

Isn't this supposed to be fixed in the latest version? See https://rt.cpan.org/Ticket/Display.html?id=105798

Tue Jul 28 12:44:58 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 28 18:53:25 2015 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #106130] Tree::DAG_Node mucks with STDIN/STDOUT
Date:	Wed, 29 Jul 2015 08:58:25 +1000
To:	bug-Tree-DAG_Node [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Slaven Yes. $many x $thanx for being aware of that. See: https://metacpan.org/source/RSAVAGE/Tree-DAG_Node-1.27/lib/Tree/DAG_Node.pm See also this discussion: https://rt.cpan.org/Ticket/Display.html?id=105798 On 29/07/15 02:44, Slaven_Rezic via RT wrote: Show quoted text

> Queue: Tree-DAG_Node > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=106130 > > > On 2015-07-28 12:27:17, schmorp@schmorp.de wrote:

>> Hi! >> >> We sometimes have crashes when loading Tree::DAG_Node in one of our >> servers. >> >> The reason turned out to be Tree::DAG_Node mucking with >> STDIN/STDOUT/STDERR in rather unexpected ways: >> >> use open qw(:std :utf8); # Undeclared streams in UTF-8. >> >> This caused data corruption because it ignores the user/program-configured >> encoding and enforces utf-8. For streams that do not support this, you get a >> crash on loading, for others you get silent data corruption. >> >> I suggest simply dropping this line - modules should not silently >> change STDIN/OUT/ERR, especially not on loading, when they ahve nothing >> whatsoever to do with these handles. >>

> > Isn't this supposed to be fixed in the latest version? See > https://rt.cpan.org/Ticket/Display.html?id=105798 > >

-- Ron Savage - savage.net.au

Wed Jul 29 04:41:17 2015 schmorp [...] schmorp.de - Correspondence added

Subject:	Re: [rt.cpan.org #106130] Tree::DAG_Node mucks with STDIN/STDOUT
Date:	Wed, 29 Jul 2015 10:41:00 +0200
To:	Slaven_Rezic via RT <bug-Tree-DAG_Node [...] rt.cpan.org>
From:	Marc Lehmann <schmorp [...] schmorp.de>

On Tue, Jul 28, 2015 at 12:44:59PM -0400, Slaven_Rezic via RT <bug-Tree-DAG_Node@rt.cpan.org> wrote: Show quoted text

> > The reason turned out to be Tree::DAG_Node mucking with > > STDIN/STDOUT/STDERR in rather unexpected ways: > > > > use open qw(:std :utf8); # Undeclared streams in UTF-8. > > > > This caused data corruption because it ignores the user/program-configured > > encoding and enforces utf-8. For streams that do not support this, you get a > > crash on loading, for others you get silent data corruption. > > > > I suggest simply dropping this line - modules should not silently > > change STDIN/OUT/ERR, especially not on loading, when they ahve nothing > > whatsoever to do with these handles. > >

> > Isn't this supposed to be fixed in the latest version? See > https://rt.cpan.org/Ticket/Display.html?id=105798

Looks like it's exactly that problem - I probably hit a stale mirror, because I only recently upgraded. -- The choice of a Deliantra, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / schmorp@schmorp.de -=====/_/_//_/\_,_/ /_/\_\

Wed Jul 29 04:45:24 2015 schmorp [...] schmorp.de - Correspondence added

Subject:	Re: [rt.cpan.org #106130] Tree::DAG_Node mucks with STDIN/STDOUT
Date:	Wed, 29 Jul 2015 10:45:08 +0200
To:	"ron [...] savage.net.au via RT" <bug-Tree-DAG_Node [...] rt.cpan.org>
From:	Marc Lehmann <schmorp [...] schmorp.de>

On Tue, Jul 28, 2015 at 06:53:26PM -0400, "ron@savage.net.au via RT" <bug-Tree-DAG_Node@rt.cpan.org> wrote: Show quoted text

> See also this discussion: > > https://rt.cpan.org/Ticket/Display.html?id=105798

Ah, I see - the problem is that you used the standard preamble _for these examples_ by Tom Crhistiansen that is meant for _these perl programs_. But perl modules are not programs, so using a standard preamble meant for other programs is a bad idea in a CPAN module in general. -- The choice of a Deliantra, the free code+content MORPG -----==- _GNU_ http://www.deliantra.net ----==-- _ generation ---==---(_)__ __ ____ __ Marc Lehmann --==---/ / _ \/ // /\ \/ / schmorp@schmorp.de -=====/_/_//_/\_,_/ /_/\_\

Mon Feb 15 16:40:08 2016 RSAVAGE [...] cpan.org - Correspondence added

Fixed in V 1.27.

Mon Feb 15 16:40:13 2016 RSAVAGE [...] cpan.org - Status changed from 'open' to 'resolved'