Bug #106061 for IO-Async: Test Failure in t/10loop-poll-io.t

Fri Jul 24 04:51:47 2015 tom [...] eborcom.com - Ticket created

Subject:

Test Failure in t/10loop-poll-io.t

I have just tried building IO::Async from CPAN (version 0.67) on FreeBSD 9.3 amd64. With both Perl 5.20.2 and bleadperl (v5.23.1-34-g56022c6) I see the following test failure: t/10loop-poll-io.t ........... 11/22 # Failed test 'exceptional socket invokes on_read_ready' # at /usr/home/tom/.cpan/build/IO-Async-0.67-3yiO2k/blib/lib/IO/Async/LoopTests.pm line 378. # got: '0' # expected: '1' # Looks like you failed 1 test of 22. t/10loop-poll-io.t ........... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/22 subtests Please let me know if you need any more information from me. Tom

Fri Jul 24 14:06:27 2015 tom [...] eborcom.com - Correspondence added

The attached patch makes tests pass for me. Does it seem reasonable?

Subject:

io-async.patch

diff --git a/lib/IO/Async/LoopTests.pm b/lib/IO/Async/LoopTests.pm index 63f1257..9d910f8 100644 --- a/lib/IO/Async/LoopTests.pm +++ b/lib/IO/Async/LoopTests.pm @@ -293,6 +293,11 @@ sub run_tests_io $loop->loop_once( 0.1 ); is( $hangup, 1, '$hangup after socket close' ); + + $loop->unwatch_io( + handle => $S1, + on_hangup => 1, + ); } my ( $Prd, $Pwr ) = IO::Async::OS->pipepair or die "Cannot pipepair - $!"; @@ -309,6 +314,11 @@ sub run_tests_io $loop->loop_once( 0.1 ); is( $hangup, 1, '$hangup after pipe close for writing' ); + + $loop->unwatch_io( + handle => $Pwr, + on_hangup => 1, + ); } # Check that combined read/write handlers can cancel each other

Tue Jul 28 18:28:15 2015 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Fri Jul 24 14:06:27 2015, TOMHUKINS wrote: Show quoted text

> The attached patch makes tests pass for me. Does it seem reasonable?

Huh. Wow, quite surprised it manages to mostly pass everywhere else without that. Patch applied, will be in next version. -- Paul Evans

Tue Jul 28 18:28:15 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 28 18:28:16 2015 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Mon Aug 03 05:27:56 2015 tom [...] eborcom.com - Correspondence added

On 2015-07-28 23:28:15, PEVANS wrote: Show quoted text

> Patch applied, will be in next version.

Thank you. The tests now pass in 0.68 on machines where they failed on 0.67. Tom

Mon Aug 03 05:27:57 2015 tom [...] eborcom.com - Status changed from 'patched' to 'resolved'

Mon Aug 03 05:27:58 2015 tom [...] eborcom.com - Fixed in 0.68 added