Bug #106051 for SOAP-Lite: broken test in 1.16

Thu Jul 23 09:20:07 2015 hsk [...] fli-leibniz.de - Ticket created

Subject:

broken test in 1.16

1.16 changed the helper script t/SOAP/Transport/HTTP/CGI/test_server.pl to use Encode::encode_utf, but that does not exist, and so test t/SOAP/Transport/HTTP/CGI.t breaks with an "unitialized value ... at Carp.pm" replacing encode_utf with encode_utf8 (what probably was intended) does not help either as it double-encodes (?) the umlaut-u: # got: 'ÃÂberall' # expected: 'Ãberall' just go back to test_server.pl from 1.14 ?

Thu Jul 23 12:21:29 2015 contyk [...] cpan.org - Cc contyk added

Thu Jul 23 13:26:25 2015 ether [...] cpan.org - Correspondence added

On 2015-07-23 06:20:07, hsk@fli-leibniz.de wrote: Show quoted text

> 1.16 changed the helper script > t/SOAP/Transport/HTTP/CGI/test_server.pl to use Encode::encode_utf, > but that does not exist, and so test t/SOAP/Transport/HTTP/CGI.t > breaks with an "unitialized value ... at Carp.pm" > > replacing encode_utf with encode_utf8 (what probably was intended) > does not help either as it double-encodes (?) the umlaut-u: > # got: 'ÃÂberall' > # expected: 'Ãberall' > > just go back to test_server.pl from 1.14 ?

The double-encoding is happening here because "use utf8;" was not included in the script, therefore latin1 encoding was used for the Ü. Encoding when transmitting network data is a very tricky thing -- this ticket might prove enlightening: https://rt.cpan.org/Ticket/Display.html?id=104433

Thu Jul 23 13:26:26 2015 The RT System itself - Status changed from 'new' to 'open'

Thu Jul 23 14:42:08 2015 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #106051] broken test in 1.16
Date:	Thu, 23 Jul 2015 11:41:50 -0700
To:	bug-SOAP-Lite [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

Thanks for the heads up Karen - giving that a shot. On Thu, Jul 23, 2015 at 10:26 AM, Karen Etheridge via RT <bug-SOAP-Lite@rt.cpan.org> wrote: Show quoted text

> Queue: SOAP-Lite > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=106051 > > > On 2015-07-23 06:20:07, hsk@fli-leibniz.de wrote:

>> 1.16 changed the helper script >> t/SOAP/Transport/HTTP/CGI/test_server.pl to use Encode::encode_utf, >> but that does not exist, and so test t/SOAP/Transport/HTTP/CGI.t >> breaks with an "unitialized value ... at Carp.pm" >> >> replacing encode_utf with encode_utf8 (what probably was intended) >> does not help either as it double-encodes (?) the umlaut-u: >> # got: 'ÃÂberall' >> # expected: 'Ãberall' >> >> just go back to test_server.pl from 1.14 ?

> > The double-encoding is happening here because "use utf8;" was not included in the script, therefore latin1 encoding was used for the Ü. > > Encoding when transmitting network data is a very tricky thing -- this ticket might prove enlightening: > https://rt.cpan.org/Ticket/Display.html?id=104433

Thu Jul 30 17:04:07 2015 dwheeler [...] cpan.org - Correspondence added

100% failure on cpan-testers. :-( http://www.cpantesters.org/distro/S/SOAP-Lite.html#SOAP-Lite-1.16 Here's a patch: --- t/SOAP/Transport/HTTP/CGI/test_server.pl.orig 2015-07-30 14:01:47.526363787 -0700 +++ t/SOAP/Transport/HTTP/CGI/test_server.pl 2015-07-30 14:02:02.675365487 -0700 @@ -16,8 +16,9 @@ my ($self, $envelope) = @_; use Encode; +use utf8; # return SOAP::Data->name('testResult')->value('Überall')->type('string'); - return SOAP::Data->name('testResult')->value(Encode::encode_utf('Überall'))->type('string'); + return SOAP::Data->name('testResult')->value(Encode::encode_utf8('Überall'))->type('string'); } 1;

Thu Jul 30 17:06:03 2015 fred [...] redhotpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #106051] broken test in 1.16
Date:	Thu, 30 Jul 2015 21:05:41 +0000
To:	bug-SOAP-Lite [...] rt.cpan.org
From:	Fred Moyer <fred [...] redhotpenguin.com>

Thanks, I've got this same fix queued for a release, should go out today or tomorrow. On Thu, Jul 30, 2015, 2:04 PM David Wheeler via RT < bug-SOAP-Lite@rt.cpan.org> wrote: Show quoted text

> Queue: SOAP-Lite > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=106051 > > > 100% failure on cpan-testers. :-( > > http://www.cpantesters.org/distro/S/SOAP-Lite.html#SOAP-Lite-1.16 > > Here's a patch: > > --- t/SOAP/Transport/HTTP/CGI/test_server.pl.orig 2015-07-30 > 14:01:47.526363787 -0700 > +++ t/SOAP/Transport/HTTP/CGI/test_server.pl 2015-07-30 > 14:02:02.675365487 -0700 > @@ -16,8 +16,9 @@ > my ($self, $envelope) = @_; > > use Encode; > +use utf8; > # return > SOAP::Data->name('testResult')->value('Überall')->type('string'); > - return > SOAP::Data->name('testResult')->value(Encode::encode_utf('Überall'))->type('string'); > + return > SOAP::Data->name('testResult')->value(Encode::encode_utf8('Überall'))->type('string'); > } > > 1; > >

Fri Jul 31 02:01:06 2015 PHRED [...] cpan.org - Correspondence added

Shipped 1.17 with a fix for this.

Fri Jul 31 02:01:08 2015 PHRED [...] cpan.org - Status changed from 'open' to 'resolved'