Bug #105996 for Dist-Zilla-Plugin-ChangelogFromGit: Mojibake in generated Changes files

Tue Jul 21 04:21:24 2015 dolmen [...] cpan.org - Ticket created

Subject:

Mojibake in generated Changes files

My name is « Olivier Mengué », not « Olivier MenguÃ© ».
Examples of failures:
https://metacpan.org/source/BINGOS/Dist-Zilla-Plugin-GithubMeta-0.54/Changes#L1
https://metacpan.org/source/GETTY/Dist-Zilla-Plugin-TravisCI-0.008/Changes#L1
https://metacpan.org/source/APOCAL/Dist-Zilla-Plugin-MinimumPerl-1.006/CommitLog#L1

It seems that DZP::ChangelogFromGit has a double encoding problem.

--
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/

Tue Jul 21 13:55:35 2015 ether [...] cpan.org - Correspondence added

On 2015-07-21 01:21:24, DOLMEN wrote: Show quoted text

> My name is « Olivier Mengué », not « Olivier MenguÃ© ». > Examples of failures: > https://metacpan.org/source/BINGOS/Dist-Zilla-Plugin-GithubMeta- > 0.54/Changes#L1 > https://metacpan.org/source/GETTY/Dist-Zilla-Plugin-TravisCI- > 0.008/Changes#L1 > https://metacpan.org/source/APOCAL/Dist-Zilla-Plugin-MinimumPerl- > 1.006/CommitLog#L1 > > It seems that DZP::ChangelogFromGit has a double encoding problem.

It appears as if the content from git is being fetched as a sequence of utf8-encoded bytes, so the thing to do here is to pass "encoding => 'bytes'" to Dist::Zilla::File::InMemory's constructor so it is not encoded again. However, Git::Repository probably should be returning data in (decoded) characters... I'm not sure how complicated this would be. Git::Wrapper is getting unicode things right now, but it's been a struggle to make it work everywhere (i.e. Windows).

Tue Jul 21 13:55:36 2015 The RT System itself - Status changed from 'new' to 'open'