Bug #105880 for Moo: Optimize generated constructor by avoiding NEXTSTATE

Wed Jul 15 10:52:53 2015 dagolden [...] cpan.org - Ticket created

CC:	rabbit [...] rabbit.us
Subject:	Optimize generated constructor by avoiding NEXTSTATE

I was looking at a generated constructor in NYTProf: https://annotate.driftt.com/view?i=b7b9a7gqxeh6xgx%2F2015-07-15_at_10.23_AM.png%2F Discussing it with ribasushi, he told me that he optimized this sort of thing in the DBIC rowparser by using "," instead of ";" to avoid the NEXTSTATE ops. The commit for it indicates a noticeable speed improvement: https://github.com/dbsrgits/dbix-class/commit/05a5ca4b9 He suggested that the generated assignment could be better expressed along these lines: ( exists $args{foo} and $new->{foo} = $args->{foo} ), ( ... ), ( ... ), ... While ugly, it's generated code anyway and probably worth it for the speed improvement.

Mon Jul 27 18:05:46 2015 ilmari [...] ilmari.org - Correspondence added

CC:	undisclosed-recipients:;
Subject:	Re: [rt.cpan.org #105880] Optimize generated constructor by avoiding NEXTSTATE
Date:	Mon, 27 Jul 2015 23:04:39 +0100
To:	bug-Moo [...] rt.cpan.org
From:	ilmari [...] ilmari.org (Dagfinn Ilmari Mannsåker)

"David Golden via RT" <bug-Moo@rt.cpan.org> writes: Show quoted text

> I was looking at a generated constructor in NYTProf: https://annotate.driftt.com/view?i=b7b9a7gqxeh6xgx%2F2015-07-15_at_10.23_AM.png%2F > > He suggested that the generated assignment could be better expressed > along these lines: > > ( exists $args{foo} and $new->{foo} = $args->{foo} ), ( ... ), ( ... ), ... > > While ugly, it's generated code anyway and probably worth it for the > speed improvement.

The generated code is not that much uglier, actually. See the 'fewer-nextstate-in-new' branch in Moo.git (https://github.com/moose/Moo/commit/fewer-nextstate-in-new) and the attached files which contain all the constructors generated by the Moo test suite, before and after the change.

Message body is not shown because sender requested not to inline it.

-- - Twitter seems more influential [than blogs] in the 'gets reported in the mainstream press' sense at least. - Matt McLeod - That'd be because the content of a tweet is easier to condense down to a mainstream media article. - Calle Dybedahl

Mon Jul 27 18:05:48 2015 The RT System itself - Status changed from 'new' to 'open'

Thu Oct 01 07:47:48 2015 ilmari+cpan [...] ilmari.org - Correspondence added

The branch, with several additional optimisations by haarg, has now been merged to master, and this speedup will be in the next release of Moo.

Thu Oct 01 07:47:53 2015 ilmari+cpan [...] ilmari.org - Status changed from 'open' to 'patched'

Mon Feb 29 17:49:56 2016 haarg [...] haarg.org - Correspondence added

Optimizations have been released in Moo 2.001000

Mon Feb 29 17:49:57 2016 haarg [...] haarg.org - Status changed from 'patched' to 'resolved'