Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 105808
Status: resolved
Priority: 0/
Queue: Net-DNS

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.01
Fixed in: (no value)



Subject: Version test for Pod::Test is broken
The version test for Pod::Test in 00-pod.t will always skip the actual test since the eval never returns true (using perl-5.22). The attached patch fixes the issue for this test, but other considerations may suggest something different.
Subject: perl-Net-DNS.src.patch
--- origsrc/Net-DNS-1.01/t/00-pod.t 2015-07-06 14:24:47.000000000 +0200 +++ src/Net-DNS-1.01/t/00-pod.t 2015-07-11 10:57:46.681317000 +0200 @@ -3,17 +3,7 @@ use strict; use Test::More; - -my %prerequisite = qw( - Test::Pod 1.45 - ); - -while ( my ( $package, $rev ) = each %prerequisite ) { - next if eval "use $package $rev"; - plan skip_all => "$package $rev required for testing POD"; - exit; -} - +use Test::Pod 1.45; my @poddirs = qw( blib demo ); my @allpods = all_pod_files(@poddirs);
On 2015-07-11 02:07:49, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> The version test for Pod::Test in 00-pod.t will always skip the actual > test since the eval never returns true (using perl-5.22). The > attached patch fixes the issue for this test, but other considerations > may suggest something different.
Please don't allow pod tests to run for normal user installs. Either move them to xt/, or guard them with: plan skip_all => 'These tests are for authors only!' unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};
From: rwfranks [...] acm.org
On Sat Jul 11 05:07:49 2015, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> The version test for Pod::Test in 00-pod.t will always skip the actual > test since the eval never returns true (using perl-5.22). The > attached patch fixes the issue for this test, but other considerations > may suggest something different.
This issue does not seem to depend on perl version. The present code assumes that "use" and "require" behave similarly, which apparently they do not. The returned value from "use" comes from "import" and is not specified.