Bug #105798 for Tree-DAG_Node: use open qw(:std :utf8) again

Fri Jul 10 14:30:55 2015 TEAM [...] cpan.org - Ticket created

Subject:

use open qw(:std :utf8) again

Hi Ron, Looks like the use open qw(:std :utf8); line is back. As mentioned before (see 1.16 release) this tends to break things when used in a module. Specifically, it turns on the UTF-8 encoding layer on STDIO when any code does 'use Tree::DAG_Node'. That's no good when code is expecting a different encoding (raw, etc.) - in my case it breaks everything in Tickit::DSL, due to Tickit::Widget::Tree loading Tree::DAG_Node. Could you take it out again? cheers, Tom

Fri Jul 10 14:32:22 2015 TEAM [...] cpan.org - Reference to ticket #88501 added

Fri Jul 10 14:33:23 2015 TEAM [...] cpan.org - Broken in 1.26 added

Fri Jul 10 14:33:23 2015 TEAM [...] cpan.org - Severity Important added

Fri Jul 10 15:30:48 2015 ether [...] cpan.org - Correspondence added

(I see this is also being done in your other distribution here: https://metacpan.org/source/RSAVAGE/Lingua-EN-GivenNames-1.00/lib/Lingua/EN/GivenNames.pm#L1)

Fri Jul 10 15:30:48 2015 The RT System itself - Status changed from 'new' to 'open'

Sat Jul 11 20:53:01 2015 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #105798] use open qw(:std :utf8) again
Date:	Sun, 12 Jul 2015 10:57:18 +1000
To:	bug-Tree-DAG_Node [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Thanx for the reports. I've used it in about 28 of my modules, some of which are Local::* ones. I copied it from Tom Christiansen's Standard Preamble: http://www.perl.com/pub/2012/04/perlunicook-standard-preamble.html I'll start taking it out, and see which modules' test still work. Tree::DAG_Node's tests do, which is reassuring. On 11/07/15 05:30, Karen Etheridge via RT wrote: Show quoted text

> Queue: Tree-DAG_Node > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105798 > > > (I see this is also being done in your other distribution here: https://metacpan.org/source/RSAVAGE/Lingua-EN-GivenNames-1.00/lib/Lingua/EN/GivenNames.pm#L1) >

-- Ron Savage - savage.net.au

Sun Jul 12 01:28:49 2015 RSAVAGE [...] cpan.org - Correspondence added

V 1.27 is now on CPAN. A new Lingua::EN::GivenNames is too, but I did not test it properly at home, so you takes your chances. I will fix the issues with some scripts/*.pl not running.

Sun Jul 12 01:28:50 2015 RSAVAGE [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jul 12 01:28:50 2015 RSAVAGE [...] cpan.org - Fixed in 1.27 added

Sun Jul 12 08:17:33 2015 TEAM [...] cpan.org - Correspondence added

Thanks for the quick fix. As mentioned before, that preamble only makes sense for a script. In a module, it's not appropriate - in general it's not a good idea to be changing I/O layers on STDIN/STDOUT/STDERR as a side effect of loading a module. Adding 'use open' to scripts is probably safe enough. cheers, Tom On 2015-07-12 01:53:01, ron@savage.net.au wrote: Show quoted text

> Hi > > Thanx for the reports. > > I've used it in about 28 of my modules, some of which are Local::* > ones. > > I copied it from Tom Christiansen's Standard Preamble: > > http://www.perl.com/pub/2012/04/perlunicook-standard-preamble.html > > I'll start taking it out, and see which modules' test still work. > > Tree::DAG_Node's tests do, which is reassuring. > > On 11/07/15 05:30, Karen Etheridge via RT wrote:

> > Queue: Tree-DAG_Node > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105798 > > > > > (I see this is also being done in your other distribution here: > > https://metacpan.org/source/RSAVAGE/Lingua-EN-GivenNames- > > 1.00/lib/Lingua/EN/GivenNames.pm#L1) > >

Sun Jul 12 18:33:58 2015 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #105798] use open qw(:std :utf8) again
Date:	Mon, 13 Jul 2015 08:38:28 +1000
To:	bug-Tree-DAG_Node [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Tom On 12/07/15 22:17, Tom Molesworth via RT wrote: Show quoted text

> Queue: Tree-DAG_Node > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105798 > > > Thanks for the quick fix. > > As mentioned before, that preamble only makes sense for a script. In a module, it's not appropriate - in general it's not a good idea to be changing I/O layers on STDIN/STDOUT/STDERR as a side effect of loading a module. > > Adding 'use open' to scripts is probably safe enough.

Agreed. Eventually, I even figured that out myself :-). Cheers. -- Ron Savage - savage.net.au