Bug #105795 for WWW-Mechanize-FireFox: Vestigial call to warn in WWW::Mechanize::Firefox::post (line 910)

Fri Jul 10 13:00:40 2015 andy.post [...] us.abb.com - Ticket created

Subject:	Vestigial call to warn in WWW::Mechanize::Firefox::post (line 910)
Date:	Fri, 10 Jul 2015 17:00:22 +0000
To:	"bug-WWW-Mechanize-FireFox [...] rt.cpan.org" <bug-WWW-Mechanize-FireFox [...] rt.cpan.org>
From:	Andy Post <andy.post [...] us.abb.com>

Hi, Max. I'm using $SIG{__WARN__} = sub { die $_[0] } to catch errors in my code that's using WWW::Mechanize::Firefox (because I eval all the calls to the module). This works really well except in one instance: Firefox.pm lines 907 - 912: # If we don't have data, encode the parameters: if( !$options{ data }) { my $req= HTTP::Request::Common::POST( $url, $options{params} ); warn $req->content; $options{ data } = $req->content; }; My guess is the call to &warn is left over from a long past debugging session. If so, would you remove it in the next release, please? Thanks, Andy

Fri Jul 10 16:53:51 2015 corion [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #105795] Vestigial call to warn in WWW::Mechanize::Firefox::post (line 910)
Date:	Fri, 10 Jul 2015 22:53:28 +0200
To:	bug-WWW-Mechanize-FireFox [...] rt.cpan.org
From:	Max Maischein <corion [...] cpan.org>

Hello Andy, Show quoted text

> I'm using $SIG{__WARN__} = sub { die $_[0] } to catch errors in my

code that's using WWW::Mechanize::Firefox (because I eval all the calls to the module). This works really well except in one instance: Show quoted text

> > Firefox.pm lines 907 - 912: > > # If we don't have data, encode the parameters: > if( !$options{ data }) { > my $req= HTTP::Request::Common::POST( $url, $options{params} ); > warn $req->content; > $options{ data } = $req->content; > }; > > My guess is the call to &warn is left over from a long past debugging session. If so, would you remove it in the next release, please?

Yep - I've removed the line in question and will release it, hopefully in the next few days. Thanks for the report! -max

Fri Jul 10 16:53:51 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Jul 06 12:49:03 2018 corion [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jul 06 12:49:03 2018 corion [...] cpan.org - Fixed in 0.79 added