Skip Menu |

This queue is for tickets about the Math-Units CPAN distribution.

Report information
The Basics
Id: 105777
Status: open
Priority: 0/
Queue: Math-Units

People
Owner: Nobody in particular
Requestors: gsullivan [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.3
Fixed in: (no value)



Subject: print_conversion error
The print_conversion sub has a bug: perl -MMath::Units -e "Math::Units::print_conversion(5, 'mm', 'in')" Undefined subroutine &Math::Units::Convert called at /cad/adi/apps/gnu/linux/x86_64/5u5/lib/perl5/site_perl/5.12.2/Math/Units.pm line 948. There is no "Convert" sub; it should be "convert" (lower-case "C"). The print_conversion sub is not mentioned in the POD. If it is supported, the above fix should be made. If it is not supported, then print_conversion sub should be deleted. I see there are a number of outstanding issues and TODO items. If you don't have the time, I'd like to pitch in and help. You could make me a co-maintainer: GSULLIVAN.
Subject: Re: [rt.cpan.org #105777] print_conversion error
Date: Fri, 10 Jul 2015 08:37:18 -0400
To: bug-Math-Units [...] rt.cpan.org
From: Ken Fox <ken [...] vulpes.com>
I haven't seen these tickets yet. Some of them are ancient! I'll put the code in my github repo and make a new CPAN release. Looking at this makes me remember how different free software was back when patches were all managed by email. - Ken On Thu, Jul 9, 2015 at 1:44 PM, Gene Sullivan via RT < bug-Math-Units@rt.cpan.org> wrote: Show quoted text
> Thu Jul 09 13:44:13 2015: Request 105777 was acted upon. > Transaction: Ticket created by GSULLIVAN > Queue: Math-Units > Subject: print_conversion error > Broken in: 1.3 > Severity: Normal > Owner: Nobody > Requestors: gsullivan@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105777 > > > > The print_conversion sub has a bug: > > perl -MMath::Units -e "Math::Units::print_conversion(5, 'mm', 'in')" > Undefined subroutine &Math::Units::Convert called at > /cad/adi/apps/gnu/linux/x86_64/5u5/lib/perl5/site_perl/5.12.2/Math/Units.pm > line 948. > > There is no "Convert" sub; it should be "convert" (lower-case "C"). > > The print_conversion sub is not mentioned in the POD. If it is supported, > the above fix should be made. If it is not supported, then > print_conversion sub should be deleted. > > I see there are a number of outstanding issues and TODO items. If you > don't have the time, I'd like to pitch in and help. You could make me a > co-maintainer: GSULLIVAN. >
Ken, Thanks for the response. If you are to make a change, my suggestion is that you delete the print_conversion sub. Since it is broken, no user code relies on it. Besides, it wasn't documented anyway. That way, there is no need to test it or document it, and test coverage results will automatically improve. And, you won't get any more of these annoying RT issues from people like me :) Gene