Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-AddFile-FromFS CPAN distribution.

Report information
The Basics
Id: 105555
Status: rejected
Priority: 0/
Queue: Dist-Zilla-Plugin-AddFile-FromFS

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: purpose?
This seems to be the same as [GatherDir], only without respect for encodings or other edge cases. You seem to be adding a lot of new modules lately. Perhaps slow down a bit and think about their usage, and prior art, before doing so?
On Mon Jun 29 12:25:21 2015, ETHER wrote: Show quoted text
> This seems to be the same as [GatherDir], only without respect for > encodings or other edge cases.
I do always try to find existing modules before creating new one, it just may be that my searching skill is bad. Show quoted text
> You seem to be adding a lot of new modules lately. Perhaps slow down a > bit and think about their usage, and prior art, before doing so?
I create lots of new modules not just "lately" (if by lately you mean some recent couple weeks). Some of them are pure experimentation, but most are created because I want/need to accomplish some task. As for GatherDir, it does not currently provide a convenient way to add a single file. So I'm currently just going to mention it in AddFile::FromFS and not remove AddFile::FromFS just yet (I'm using it in lib-filter currently to include Module::List::WithPath into t/). I'll look into the encoding issue. Thanks for the input(s).
I've replaced the use of DZF:Memory with DZF:OnDisk to avoid encoding issues. I've also taken a second look at GatherDir, but it currently does not offer a way to include a single file. I've created a wishlist ticket for proposing this feature: https://rt.cpan.org/Ticket/Display.html?id=105583 I'm closing this ticket as rejected. If you feel that is not appropriate, feel free to reopen it. Thanks.