Skip Menu |

This queue is for tickets about the DateTime-TimeZone-Local-Win32 CPAN distribution.

Report information
The Basics
Id: 105519
Status: resolved
Priority: 0/
Queue: DateTime-TimeZone-Local-Win32

People
Owner: DAPINK [...] cpan.org
Requestors: stro [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 1.84
Fixed in: 1.85



Subject: Test suite fails because of circular prereq
C:\bin\dev\Perl64\bin\perl.exe "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib\lib', 'blib\arch')" t/*.t # Failed test 'DateTime/TimeZone/Local/Win32.pm loaded ok' # at t/00-compile.t line 37. # got: '512' # expected: '0' Can't locate DateTime/TimeZone/Local.pm in @INC (you may need to install the DateTime::TimeZone::Local module) (@INC contains: C:\bin\dev\Perl64\cpan\build\DateTime-TimeZone-Local-Win32-1.84-qIsoZD\blib\arch C:\bin\dev\Perl64\cpan\build\DateTime-TimeZone-Local-Win32-1.84-qIsoZD\blib\lib C:\bin\dev\Perl64\cpan\build\DateTime-TimeZone-Local-Win32-1.84-qIsoZD\blib\lib C:\bin\dev\Perl64\cpan\build\DateTime-TimeZone-Local-Win32-1.84-qIsoZD\blib\arch C:/bin/dev/Perl64/site/lib C:/bin/dev/Perl64/lib .) at C:/bin/dev/Perl64/lib/parent.pm line 20. BEGIN failed--compilation aborted at C:\bin\dev\Perl64\cpan\build\DateTime-TimeZone-Local-Win32-1.84-qIsoZD\blib\lib/DateTime/TimeZone/Local/Win32.pm line 11. Compilation failed in require at -e line 1. # Looks like you failed 1 test of 1. t/00-compile.t ......... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests # # Versions for all modules listed in MYMETA.json (including optional ones): # # === Configure Requires === # # Module Want Have # ------------------- ---- ---- # ExtUtils::MakeMaker any 6.98 # # === Build Requires === # # Module Want Have # ------------------- ---- ---- # ExtUtils::MakeMaker any 6.98 # # === Test Requires === # # Module Want Have # ------------------- ---- -------- # ExtUtils::MakeMaker any 6.98 # File::Basename any 2.85 # File::Spec any 3.48_01 # IO::Handle any 1.35 # IPC::Open3 any 1.16 # Sys::Hostname any 1.1801 # Test::More 0.88 1.001014 # constant any 1.31 # lib any 0.63 # # === Test Recommends === # # Module Want Have # ---------- -------- -------- # CPAN::Meta 2.120900 2.150005 # # === Runtime Requires === # # Module Want Have # ------------------ ---- ----- # Try::Tiny any 0.22 # Win32::TieRegistry 0.27 0.28 # parent any 0.228 # strict any 1.08 # warnings any 1.23 # t/00-report-prereqs.t .. ok t/01-local-win32.t ..... skipped: These tests run only when DateTime and DateTime::TimeZone are present. Test Summary Report ------------------- t/00-compile.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=3, Tests=2, 0 wallclock secs ( 0.01 usr + 0.02 sys = 0.03 CPU) Result: FAIL Failed 1/3 test programs. 1/2 subtests failed. dmake.exe: Error code 255, while making 'test_dynamic' (C:\bin\dev\Perl64\site\bin\dmake.exe test exited with 65280) DateTime/TimeZone/Local.pm cannot be used as parent because it's not installed and it cannot be installed since DateTime-TimeZone now uses Local::Win32 as prerequisite: http://cpansearch.perl.org/src/DROLSKY/DateTime-TimeZone-1.92/Makefile.PL I will file similar bug to DateTime-TimeZone queue. -- Serguei Trouchelle
On Fri Jun 26 21:10:48 2015, STRO wrote: Show quoted text
> I will file similar bug to DateTime-TimeZone queue.
There's no need for that. This can and should be fixed in this distro alone.
On 2015-06-26 18:10:48, STRO wrote: Show quoted text
> C:\bin\dev\Perl64\bin\perl.exe "-MExtUtils::Command::MM" "- > MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, > 'blib\lib', 'blib\arch')" t/*.t > > # Failed test 'DateTime/TimeZone/Local/Win32.pm loaded ok' > # at t/00-compile.t line 37. > # got: '512' > # expected: '0' > Can't locate DateTime/TimeZone/Local.pm in @INC (you may need to > install the DateTime::TimeZone::Local module) (@INC contains:
This can be solved by making the compile test author-only. I've been recommending keeping [Test::Compile] in author-mode for a few years now, due to the problems that can be caused by unconditionally loading all code on the author side (and if you have good test coverage, you're already loading all the usual things anyway.)
On Fri Jun 26 21:28:24 2015, ETHER wrote: Show quoted text
> > Can't locate DateTime/TimeZone/Local.pm in @INC (you may need to > > install the DateTime::TimeZone::Local module) (@INC contains:
> > This can be solved by making the compile test author-only.
No, because it's not a compile test problem. It's a distro problem. This test did exactly why it's there: to make a sanity check and find a problem. Test is correct and did its job. -- Serguei Trouchelle
The problem is fixed.