Bug #105449 for Hypothesis-API: Stop mucking with MYMETA.json

Tue Jun 23 14:52:09 2015 ether [...] cpan.org - Ticket created

Subject:

Stop mucking with MYMETA.json

I'm not sure what you're trying to do here, but this is very wrong and should be removed: https://metacpan.org/source/BBARKER/Hypothesis-API-0.08/Makefile.PL#L54

Tue Jun 23 15:08:53 2015 brandon.barker [...] cornell.edu - Correspondence added

Subject:	Re: [rt.cpan.org #105449] Stop mucking with MYMETA.json
Date:	Tue, 23 Jun 2015 15:08:37 -0400
To:	bug-Hypothesis-API [...] rt.cpan.org
From:	Brandon Barker <brandon.barker [...] cornell.edu>

Thanks, this is my trivial attempt to package META as part of the (my) build process. Perhaps I should add an option to Makefile.PL for this purpose. On Jun 23, 2015 2:52 PM, "Karen Etheridge via RT" < bug-Hypothesis-API@rt.cpan.org> wrote: Show quoted text

> Tue Jun 23 14:52:09 2015: Request 105449 was acted upon. > Transaction: Ticket created by ETHER > Queue: Hypothesis-API > Subject: Stop mucking with MYMETA.json > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: ether@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105449 > > > > I'm not sure what you're trying to do here, but this is very wrong and > should be removed: > https://metacpan.org/source/BBARKER/Hypothesis-API-0.08/Makefile.PL#L54 >

Tue Jun 23 15:08:53 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Jun 23 17:37:19 2015 ether [...] cpan.org - Correspondence added

On 2015-06-23 12:08:53, brandon.barker@cornell.edu wrote: Show quoted text

> Thanks, this is my trivial attempt to package META as part of the (my) > build process. Perhaps I should add an option to Makefile.PL for this > purpose.

"make dist" will do this for you. MYMETA.json is only ever relevant to one specific machine; it is never valid to ship the contents of that to apply to everyone.

Tue Jun 23 23:20:11 2015 brandon.barker [...] cornell.edu - Correspondence added

Subject:	Re: [rt.cpan.org #105449] Stop mucking with MYMETA.json
Date:	Tue, 23 Jun 2015 23:19:59 -0400
To:	bug-Hypothesis-API [...] rt.cpan.org
From:	Brandon Barker <brandon.barker [...] cornell.edu>

Thanks for the clarifications and suggestions - I looked into 'make dist' a bit just now. I guess my only quibble is that it creates a new directory and/or tar file. Ideally I'd like to be able to simply download a tar.gz from github and upload that to CPAN. But as you point out, my current method incurs some issues. I can certainly write a quick hack to satisfy both issues, but thought I'd write back to see if you had any more seasoned advice on the recommended way to accomplish this. Best, On Tue, Jun 23, 2015 at 5:37 PM, Karen Etheridge via RT < bug-Hypothesis-API@rt.cpan.org> wrote: Show quoted text

> Queue: Hypothesis-API > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105449 > > > On 2015-06-23 12:08:53, brandon.barker@cornell.edu wrote:

> > Thanks, this is my trivial attempt to package META as part of the (my) > > build process. Perhaps I should add an option to Makefile.PL for this > > purpose.

> > "make dist" will do this for you. MYMETA.json is only ever relevant to one > specific machine; it is never valid to ship the contents of that to apply > to everyone. > > >

-- Brandon E. Barker http://www.cac.cornell.edu/barker/

Wed Jun 24 13:42:37 2015 ether [...] cpan.org - Correspondence added

On 2015-06-23 20:20:11, brandon.barker@cornell.edu wrote: Show quoted text

> Thanks for the clarifications and suggestions - I looked into 'make dist' a > bit just now. > > I guess my only quibble is that it creates a new directory and/or tar file. > Ideally I'd like to be able to simply download a tar.gz from github and > upload that to CPAN. But as you point out, my current method incurs some > issues. > > I can certainly write a quick hack to satisfy both issues, but thought I'd > write back to see if you had any more seasoned advice on the recommended > way to accomplish this.

Yes, you do need to create a new local build directory and tarball, in order to upload it. GitHub does not have the tools installed to create a distribution tarball that is installable from the CPAN. This document covers the steps: http://perldoc.perl.org/perlnewmod.html#Step-by-step:-Distributing-your-module If you don't like ExtUtils::MakeMaker, there are other packaging tools available to you. The simplest to use are: - Module::Build::Tiny (the user-side installer) and App::ModuleBuildTiny (the author-side packaging tool) - Dist::Milla Additionally, this documentation will be of use to you: - https://pause.perl.org/pause/authenquery?ACTION=pause_04about

Wed Jun 24 14:48:26 2015 ether [...] cpan.org - Correspondence added

On 2015-06-24 10:42:37, ETHER wrote: Show quoted text

> - Dist::Milla

I meant to say Minilla here -- Dist::Milla is *not* lightweight :)

Fri Jun 26 18:07:26 2015 brandon.barker [...] cornell.edu - Correspondence added

Subject:	Re: [rt.cpan.org #105449] Stop mucking with MYMETA.json
Date:	Fri, 26 Jun 2015 18:07:09 -0400
To:	bug-Hypothesis-API [...] rt.cpan.org
From:	Brandon Barker <brandon.barker [...] cornell.edu>

I've created what I believe to be a fix to the issue without changing the build system in 0.09, but created a feature issue for that at https://github.com/bbarker/Hypothesis-API/issues/6 If you believe the issue to be resolved feel free to close the ticket, and thanks again for the feedback. On Wed, Jun 24, 2015 at 2:48 PM, Karen Etheridge via RT < bug-Hypothesis-API@rt.cpan.org> wrote: Show quoted text

> Queue: Hypothesis-API > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105449 > > > On 2015-06-24 10:42:37, ETHER wrote: >

> > - Dist::Milla

> > I meant to say Minilla here -- Dist::Milla is *not* lightweight :) > >

-- Brandon E. Barker http://www.cac.cornell.edu/barker/

Fri Jun 26 18:14:16 2015 ether [...] cpan.org - Correspondence added

On 2015-06-26 15:07:26, brandon.barker@cornell.edu wrote: Show quoted text

> I've created what I believe to be a fix to the issue without changing the > build system in 0.09, but created a feature issue for that at > https://github.com/bbarker/Hypothesis-API/issues/6 > > If you believe the issue to be resolved feel free to close the ticket, and > thanks again for the feedback.

Cool, your changes to https://github.com/bbarker/Hypothesis-API/blob/master/Makefile.PL look good... I noticed that the 'dist' and 'clean' arguments (lines 45,46) are not needed, so you can remove those. I'll continue asking questions on your github ticket. :)

Fri Jun 26 18:14:22 2015 ether [...] cpan.org - Status changed from 'open' to 'resolved'