Skip Menu |

This queue is for tickets about the Digest-SHA CPAN distribution.

Report information
The Basics
Id: 105371
Status: resolved
Priority: 0/
Queue: Digest-SHA

People
Owner: mshelor [...] cpan.org
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: 5.95
Fixed in: 5.96



Subject: [PATCH] Import only used symbols from Fcntl
Hi,

In Disgest/SHA.pm, line 8:

    use Fcntl;

Fcntl exports many symbols, but the only one used in Digest::SHA is O_RDONLY. The other imports are useless and just take space in the stash.

Patch attached.


-- 
Olivier Mengué - http://perlresume.org/DOLMEN - https://gratipay.com/dolmen/
Subject: Fcntl-imports.patch
--- lib/Digest/SHA.pm.orig 2015-01-10 21:09:47.000000000 +0100 +++ lib/Digest/SHA.pm 2015-06-19 10:12:48.468427132 +0200 @@ -5,7 +5,7 @@ use strict; use warnings; use vars qw($VERSION @ISA @EXPORT @EXPORT_OK); -use Fcntl; +use Fcntl qw(O_RDONLY); use integer; $VERSION = '5.95';
Yes, you're correct. Thanks for the patch. Mark