Skip Menu |

This queue is for tickets about the MIME-Types CPAN distribution.

Report information
The Basics
Id: 105267
Status: resolved
Priority: 0/
Queue: MIME-Types
People
Owner: Nobody in particular
Requestors: miyagawa [...] gmail.com
Cc: ribasushi [...] leporine.io
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Jun 16 11:05:42 2015 miyagawa [...] gmail.com - Ticket created
Subject: MIME-Types-2.10 broke 5.8 once again
Date: Tue, 16 Jun 2015 15:05:17 +0000
To: bug-MIME-Types [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
The use of // doesn't make the code compile on perl 5.8. diff --git a/lib/MIME/Types.pm b/lib/MIME/Types.pm index b61e561..a216774 100644 --- a/lib/MIME/Types.pm +++ b/lib/MIME/Types.pm @@ -167,7 +167,7 @@ sub httpAccept($) $ !x or next; my $mime = "$1/$2$4"; - my $q = $3 // 1; # q, default=1 + my $q = $3; $q = 1 unless defined $q; # q, default=1 # most complex first $q += $4 ? +0.01 : $1 eq '*' ? -0.02 : $2 eq '*' ? -0.01 : 0;
  Tue Jun 16 11:18:20 2015 solutions [...] overmeer.net - Correspondence added
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Tue, 16 Jun 2015 17:18:04 +0200
To: "miyagawa [...] gmail.com via RT" <bug-MIME-Types [...] rt.cpan.org>
From: Mark Overmeer <solutions [...] overmeer.net>
* miyagawa@gmail.com via RT (bug-MIME-Types@rt.cpan.org) [150616 15:06]: Show quoted text
> Tue Jun 16 11:05:42 2015: Request 105267 was acted upon. > Subject: MIME-Types-2.10 broke 5.8 once again > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105267 > > The use of // doesn't make the code compile on perl 5.8.
Once we should end supporting 5.8 Released 2.11 -- MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Tue Jun 16 11:18:21 2015 The RT System itself - Status changed from 'new' to 'open'
  Tue Jun 16 11:21:27 2015 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Tue, 16 Jun 2015 15:21:03 +0000
To: bug-MIME-Types [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
I totally understand your pain, but MIME::Types is kind of a distribution with a lot of downstream modules (Plack, in my case, with its awful lot of own downstream in the wild). Which means you shouldn't take lightly to make a decision to drop 5.8. If you ever decide to drop 5.8, let me know though - I will probably end up forking the code internally inside Plack. On Tue, Jun 16, 2015 at 8:18 AM Mark Overmeer via RT < bug-MIME-Types@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=105267 > > > * miyagawa@gmail.com via RT (bug-MIME-Types@rt.cpan.org) [150616 15:06]:
> > Tue Jun 16 11:05:42 2015: Request 105267 was acted upon. > > Subject: MIME-Types-2.10 broke 5.8 once again > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105267 > > > The use of // doesn't make the code compile on perl 5.8.
> > Once we should end supporting 5.8 > > Released 2.11 > -- > MarkOv > > ------------------------------------------------------------------------ > Mark Overmeer MSc MARKOV Solutions > Mark@Overmeer.net solutions@overmeer.net > http://Mark.Overmeer.net http://solutions.overmeer.net > > >
  Tue Jun 16 11:39:00 2015 ribasushi [...] leporine.io - Cc RIBASUSHI added
  Tue Jun 16 12:58:59 2015 ether [...] cpan.org - Correspondence added
RT-Send-CC: solutions [...] overmeer.net
May I suggest adding this as an author test -- this has saved me from many broken releases in the past: use Test::More; use Test::MinimumVersion; all_minimum_version_ok("5.008");
  Tue Jun 16 16:07:56 2015 Mark [...] Overmeer.net - Correspondence added
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Tue, 16 Jun 2015 22:07:40 +0200
To: Karen Etheridge via RT <bug-MIME-Types [...] rt.cpan.org>
From: Mark Overmeer <mark [...] overmeer.net>
* Karen Etheridge via RT (bug-MIME-Types@rt.cpan.org) [150616 16:59]: Show quoted text
> Queue: MIME-Types > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105267 > > > May I suggest adding this as an author test -- this has saved me from > many broken releases in the past: > > use Test::More; > use Test::MinimumVersion; > all_minimum_version_ok("5.008");
I have added this. Thanks. Perl 5.10 is seven years old. We keep the intelligence of our CPAN modules low to support people who do not upgrade their end-of-life operating systems. I do know of one company which runs 5.6. They maintain a patch-set to backport CPAN modules onto their Perl version. Maybe we can make a standard process for that: smart modules on CPAN and downgrade patches. So: this "bug" was actually not a mistake... but I have taken it back. -- Regards, MarkOv ------------------------------------------------------------------------ Mark Overmeer MSc MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Tue Jun 16 18:47:10 2015 miyagawa [...] gmail.com - Correspondence added
CC: ribasushi [...] cpan.org
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Tue, 16 Jun 2015 22:46:49 +0000
To: bug-MIME-Types [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
On Tue, Jun 16, 2015 at 1:08 PM Mark Overmeer via RT < bug-MIME-Types@rt.cpan.org> wrote: Show quoted text
> So: this "bug" was actually not a mistake... but I have taken it back. > >
Well, if your module claims it runs on 5.8, and then doesn't compile, it is a mistake :) Speaking of which I noticed that your Makefile.PL requris 5.8.8, which is higher than what Plack currently supports - so I might consider updating what Plack requires, or do something else about it.
  Thu Jun 18 17:52:54 2015 ether [...] cpan.org - Correspondence added
RT-Send-CC: Mark [...] Overmeer.net, ribasushi [...] cpan.org
On 2015-06-16 15:47:10, miyagawa@gmail.com wrote: Show quoted text
> On Tue, Jun 16, 2015 at 1:08 PM Mark Overmeer via RT < > bug-MIME-Types@rt.cpan.org> wrote: >
> > So: this "bug" was actually not a mistake... but I have taken it back. > > > >
> Well, if your module claims it runs on 5.8, and then doesn't compile, it is > a mistake :) > > Speaking of which I noticed that your Makefile.PL requris 5.8.8, which is > higher than what Plack currently supports - so I might consider updating > what Plack requires, or do something else about it.
Might as well lower that to 5.8.0 and see what the smokers say?
  Fri Jun 19 01:42:19 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-06-18 17:52:54, ETHER wrote: Show quoted text
> On 2015-06-16 15:47:10, miyagawa@gmail.com wrote:
> > On Tue, Jun 16, 2015 at 1:08 PM Mark Overmeer via RT < > > bug-MIME-Types@rt.cpan.org> wrote: > >
> > > So: this "bug" was actually not a mistake... but I have taken it > > > back. > > > > > >
> > Well, if your module claims it runs on 5.8, and then doesn't compile, > > it is > > a mistake :) > > > > Speaking of which I noticed that your Makefile.PL requris 5.8.8, > > which is > > higher than what Plack currently supports - so I might consider > > updating > > what Plack requires, or do something else about it.
> > Might as well lower that to 5.8.0 and see what the smokers say?
Tried it with perl 5.8.4 --- all tests pass.
  Fri Jun 19 05:57:04 2015 ribasushi [...] leporine.io - Correspondence added
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Fri, 19 Jun 2015 11:56:52 +0200
To: bug-MIME-Types [...] rt.cpan.org
From: Peter Rabbitson <ribasushi [...] cpan.org>
On 06/19/2015 07:42 AM, Slaven_Rezic via RT wrote: Show quoted text
> Tried it with perl 5.8.4 --- all tests pass.
Same with 5.8.1 - log attached:

Message body is not shown because sender requested not to inline it.

  Fri Jul 10 18:27:37 2015 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Fri, 10 Jul 2015 22:27:13 +0000
To: bug-MIME-Types [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Just a side note, the travis CI error was due to my particular setup, and Plack actually *does not* depend on MIME::Types since a long time ago. It's just required in one of my tests and I force install them in my CI setup to make sure it runs successfully. Since MIME::Types is used by lot of libraries and frameworks, supporting lower versions would still make a lot of sense, but I withdraw my request of "because Plack depends on it." On Fri, Jun 19, 2015 at 2:57 AM Peter Rabbitson via RT < bug-MIME-Types@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=105267 > > > On 06/19/2015 07:42 AM, Slaven_Rezic via RT wrote:
> > Tried it with perl 5.8.4 --- all tests pass.
> Same with 5.8.1 - log attached: > > >
  Sat Jul 11 07:12:11 2015 solutions [...] overmeer.net - Correspondence added
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Sat, 11 Jul 2015 13:11:36 +0200
To: "miyagawa [...] gmail.com via RT" <bug-MIME-Types [...] rt.cpan.org>
From: Mark Overmeer <solutions [...] overmeer.net>
* miyagawa@gmail.com via RT (bug-MIME-Types@rt.cpan.org) [150710 22:27]: Show quoted text
> Queue: MIME-Types > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105267 > > > Since MIME::Types is used by lot of libraries and frameworks, supporting > lower versions would still make a lot of sense, but I withdraw my request > of "because Plack depends on it."
It's already fixed for a long time, just after your original report. You may reconsider using the module, while it is contains the most complete list of mime-types you can find on internet (it combines 10 different sources) And it has a much smaller footprint than before. -- MarkOv ------------------------------------------------------------------------ drs Mark A.C.J. Overmeer MARKOV Solutions Mark@Overmeer.net solutions@overmeer.net http://Mark.Overmeer.net http://solutions.overmeer.net
  Sat Jul 11 12:09:43 2015 miyagawa [...] gmail.com - Correspondence added
CC: ribasushi [...] cpan.org
Subject: Re: [rt.cpan.org #105267] MIME-Types-2.10 broke 5.8 once again
Date: Sat, 11 Jul 2015 16:09:20 +0000
To: bug-MIME-Types [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
On Sat, Jul 11, 2015 at 4:12 AM Mark Overmeer via RT < bug-MIME-Types@rt.cpan.org> wrote: Show quoted text
> > Since MIME::Types is used by lot of libraries and frameworks, supporting > > lower versions would still make a lot of sense, but I withdraw my request > > of "because Plack depends on it."
> > It's already fixed for a long time, just after your original report. >
No it's not. I was talking about the requirement of perl 5.8.8 rather than, say, 5.8.1 which currently Plack supports (and ribasushi et al confirmed that MIME::Types seems to work fine on). If you're still confused, it is this line in Makefile.PL: https://metacpan.org/source/MARKOV/MIME-Types-2.11/Makefile.PL#L3
  Fri Mar 11 08:34:43 2016 ribasushi [...] leporine.io - Correspondence added
On Sat Jul 11 18:09:43 2015, miyagawa@gmail.com wrote: Show quoted text
> > No it's not. I was talking about the requirement of perl 5.8.8 rather > than, > say, 5.8.1 which currently Plack supports (and ribasushi et al > confirmed > that MIME::Types seems to work fine on). >
This has been fixed some time ago, I just tested a Plack install on a virgin 5.8.4 with no ill effects. This ticket can be closed (I lack perms to do so)
  Fri Mar 11 08:45:36 2016 MARKOV [...] cpan.org - Correspondence added
solved long time ago ;-)
  Fri Mar 11 08:45:43 2016 MARKOV [...] cpan.org - Status changed from 'open' to 'resolved'