Skip Menu |

This queue is for tickets about the Net-OpenSSH CPAN distribution.

Report information
The Basics
Id: 105253
Status: resolved
Priority: 0/
Queue: Net-OpenSSH
People
Owner: Nobody in particular
Requestors: seatek [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Jun 15 21:59:04 2015 seatek [...] gmail.com - Ticket created
Subject: parse_connection_opts target regex too restrictive
Date: Tue, 16 Jun 2015 01:58:43 +0000
To: bug-Net-OpenSSH [...] rt.cpan.org
From: Mark Rushing <seatek [...] gmail.com>
Parsing the $target in the way the current regex does makes it impossible for users using Samba domain logins to use the module (unless they disable the use of domain names in the user string). For example, if your machine is part of the Samba/Kerberos domain SAMBA.MYDOMAIN.COM -- and your machine name is myhost.mydomain.com -- you log in via SSH like this: ssh username@SAMBA.MYDOMAIN.COM@myhost.mydomain.com This Perl modules fail with the error bad host/target specification in this instance, I imagine because it's pulling the "username@" as the username, and making the rest be the host to connect to, which of course isn't right. We need to split from the furthest right '@'. BTW thank you so much for this module. It's been incredibly helpful and wonderful to have, and I greatly, greatly appreciate it. :)
  Wed Jun 17 03:10:56 2015 salva [...] cpan.org - Correspondence added
I have released version 0.65_02 that should solve this issue. Could you check it? https://metacpan.org/release/SALVA/Net-OpenSSH-0.65_02
  Wed Jun 17 03:10:56 2015 The RT System itself - Status changed from 'new' to 'open'
  Wed Jun 17 06:05:52 2015 seatek [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #105253] parse_connection_opts target regex too restrictive
Date: Wed, 17 Jun 2015 10:05:29 +0000
To: bug-Net-OpenSSH [...] rt.cpan.org
From: Mark Rushing <seatek [...] gmail.com>
I just did. Flawless!! :) Thank you Salvador! I wish I could have sent you a patch, but I'm terrible with extended expressions. Looks like you had quite a bit more work going on there, too, though. Thank you so much, yet again. On Wed, Jun 17, 2015 at 12:10 AM Salvador Fandino Garcia via RT < bug-Net-OpenSSH@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=105253 > > > I have released version 0.65_02 that should solve this issue. > > Could you check it? > > https://metacpan.org/release/SALVA/Net-OpenSSH-0.65_02 >
  Wed Jun 17 06:16:23 2015 sfandino [...] yahoo.com - Correspondence added
Subject: Re: [rt.cpan.org #105253] parse_connection_opts target regex too restrictive
Date: Wed, 17 Jun 2015 10:16:10 +0000 (UTC)
To: "bug-Net-OpenSSH [...] rt.cpan.org" <bug-Net-OpenSSH [...] rt.cpan.org>
From: Salvador Fandino <sfandino [...] yahoo.com>
Show quoted text
----- Original Message -----
> From: Mark Rushing via RT <bug-Net-OpenSSH@rt.cpan.org> > To: > Cc: > Sent: Wednesday, June 17, 2015 12:05 PM > Subject: Re: [rt.cpan.org #105253] parse_connection_opts target regex too restrictive > > Queue: Net-OpenSSH > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105253 > > > I just did. Flawless!! :) Thank you Salvador! I wish I could have sent you
> a patch, but I'm terrible with extended expressions.
Well, actually, the difficult part was not fixing the regex but checking that nothing else was broken! Thank you for reporting the bug!
  Wed Jun 17 06:16:52 2015 salva [...] cpan.org - Status changed from 'open' to 'resolved'