Bug #105221 for HTML-FormatExternal: libhtml-formatexternal-perl: autopkgtest failure: TERM not set

Sat Jun 13 18:08:23 2015 gregoa [...] cpan.org - Ticket created

From:	gregoa [...] cpan.org
Subject:	libhtml-formatexternal-perl: autopkgtest failure: TERM not set

We have the following bug reported to the Debian package of HTML-FormatExternal (https://bugs.debian.org/788639): It doesn't seem to be a bug in the packaging, so you may want to take a look. Thanks! Additional information (cf. the link above): t/FormatExternal.t always fails the test for HTML::FormatText::Netrik if - TERM is not set, or - if netrik (or curses?) don't know the terminal ------8<-----------8<-----------8<-----------8<-----------8<----- Package: libhtml-formatexternal-perl Version: 22-1 User: debian-perl@lists.debian.org Usertags: autopkgtest This package fails its autopkgtest checks on ci.debian.net. It looks like the tests get run with an unset TERM variable, but /usr/bin/netrik fails with that. Possibly the best fix is to patch the tests to skip HTML::FormatText::Netrik tests if TERM is unset. From <http://ci.debian.net/packages/libh/libhtml-formatexternal-perl/unstable/amd64/>: # HTML::FormatText::Netrik ok 165 - use HTML::FormatText::Netrik; ok 166 - HTML::FormatText::Netrik VERSION method ok 167 - HTML::FormatText::Netrik VERSION variable # HTML::FormatText::Netrik program_full_version $VAR1 = 'usage: /usr/bin/netrik html-file # or: /usr/bin/netrik - (read from stdin) # '; ok 168 - program_full_version() from class ok 169 - program_full_version() from obj # HTML::FormatText::Netrik program_version $VAR1 = '(not reported)'; ok 170 - HTML::FormatText::Netrik program_version() from class ok 171 - HTML::FormatText::Netrik program_version() from obj TERM environment variable not set. not ok 172 - HTML::FormatText::Netrik through class # Failed test 'HTML::FormatText::Netrik through class' # at t/FormatExternal.t line 130. # '' # doesn't match '(?^:Hello)' TERM environment variable not set. not ok 173 - HTML::FormatText::Netrik through formatter object [...] Test Summary Report ------------------- t/FormatExternal.t (Wstat: 3072 Tests: 284 Failed: 12) Failed tests: 172-173, 175-176, 195-202 Non-zero exit status: 12 Files=3, Tests=303, 4 wallclock secs ( 0.10 usr 0.03 sys + 0.91 cusr 1.95 csys = 2.99 CPU) Result: FAIL -- Niko Tyni ntyni@debian.org ------8<-----------8<-----------8<-----------8<-----------8<----- Thanks for considering, gregor herrmann, Debian Perl Group

Sun Jun 14 04:58:28 2015 KRYDE [...] cpan.org - Correspondence added

Thanks, I didn't know netrik needed a TERM setting even for --dump. I stuck in TERM=dumb if not already set. New version 24 now uploaded should be better.

Sun Jun 14 04:58:28 2015 The RT System itself - Status changed from 'new' to 'open'

Sun Jun 14 04:58:32 2015 KRYDE [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jun 14 12:10:10 2015 gregoa [...] debian.org - Correspondence added

Subject:	Re: [rt.cpan.org #105221] libhtml-formatexternal-perl: autopkgtest failure: TERM not set
Date:	Sun, 14 Jun 2015 18:09:43 +0200
To:	Kevin Ryde via RT <bug-HTML-FormatExternal [...] rt.cpan.org>
From:	gregor herrmann <gregoa [...] debian.org>

On Sun, 14 Jun 2015 04:58:28 -0400, Kevin Ryde via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=105221 > > > Thanks, I didn't know netrik needed a TERM setting even for --dump. I stuck in TERM=dumb if not already set. New version 24 now uploaded should be better.

Thanks. The fix probably works when TERM is unset, but it fails when netrik or curses don't like the value of TERM. I.e. I still get: # Failed test 'HTML::FormatText::Netrik format_file() filename "/tmp/LMml57ZRfO/%57"' # at t/FormatExternal.t line 294. # '' # doesn't match '(?^:body.*text)' 'rxvt-unicode-256color': unknown terminal type. and Test Summary Report ------------------- t/FormatExternal.t (Wstat: 3072 Tests: 284 Failed: 12) Failed tests: 172-173, 175-176, 195-202 Non-zero exit status: 12 Files=5, Tests=316, 1 wallclock secs ( 0.08 usr 0.00 sys + 0.75 cusr 0.16 csys = 0.99 CPU) Result: FAIL Failed 1/5 test programs. 12/316 subtests failed. Makefile:897: recipe for target 'test_dynamic' failed I think hardcoding something like local $ENV{TERM} = 'dumb'; in t/FormatExternal.t might get over this nuisance. (In Debian, we can also run the tests with TERM=dumb or add a build dependency on ncurses-term. So there's no urgency here.) Cheers, gregor -- .''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06 : :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/ `. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe `- NP: Funny van Dannen: Genug gute Menschen

Download signature.asc
application/pgp-signature 949b

Message body not shown because it is not plain text.

Mon Jun 15 05:28:06 2015 user42_kevin [...] yahoo.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #105221] libhtml-formatexternal-perl: autopkgtest failure: TERM not set
Date:	Mon, 15 Jun 2015 19:22:57 +1000
To:	"gregor herrmann via RT" <bug-HTML-FormatExternal [...] rt.cpan.org>
From:	Kevin Ryde <user42_kevin [...] yahoo.com.au>

"gregor herrmann via RT" <bug-HTML-FormatExternal@rt.cpan.org> writes: Show quoted text

> > # Failed test 'HTML::FormatText::Netrik format_file() filename "/tmp/LMml57ZRfO/%57"' > # at t/FormatExternal.t line 294. > # '' > # doesn't match '(?^:body.*text)' > 'rxvt-unicode-256color': unknown terminal type.

I'm not sure in my code I ought to try to detect/correct an unknown term type. I'd like to hope if the user made a setting then it should be used. Though also netrik would be better not needing a term type when --dump, but that would be new work at its end ... Show quoted text

> I think hardcoding something like > local $ENV{TERM} = 'dumb'; > in t/FormatExternal.t might get over this nuisance.

Tempting. Show quoted text

> (In Debian, we can also run the tests with TERM=dumb or add a build > dependency on ncurses-term.

Oh, I see, rxvt-unicode-256color is in ncurses-term which is only priority standard. Hmm. I'd think if the test environment sets a TERM type then it probably should be a known one, otherwise it might merely explore how many things quietly depend on a term type. Unless that's the idea ... :-) Though also for my html stuff the intention is to work in batch mode etc etc, so no term setting, even no controlling tty at all, hopefully. Show quoted text

> So there's no urgency here.)

I'm slightly away for a few days this week. -- These prestigious wrought-iron security gates are bullet-proof, bomb-proof, and battering-ram resistant.