Bug #105168 for Image-Hash: Bug in Image::Hash b2h subprogramm

Thu Jun 11 02:56:37 2015 disop2004 [...] mail.ru - Ticket created

Subject:	Bug in Image::Hash b2h subprogramm
Date:	Thu, 11 Jun 2015 09:56:25 +0300
To:	bug-Image-Hash [...] rt.cpan.org
From:	Igor . <disop2004 [...] mail.ru>

hello Runar Buvik. thanks for usefull util "Image::Hash" , but it have some bug. testing system: Win x64 ; perl 5, version 14, subversion 2 (v5.14.2) built for MSWin32-x64-multi-thread (ActiveState Perl) Bug found while testing included image print-hashes-for-files.pl "images/FishEyeViewofAtlantis.jpg" phash: GD : AB802A1820002000 1010101110000000001010100001100000100000000000000010000000000000 ImageMagick : AB8022188200020 1010101110000000001000100001100000001000001000000000000000100000 Bug: HEX LENGTH - is different ! ( length AB802A1820002000 vs length AB8022188200020 ) (with equal binary length) . trouble with sub "b2h". simplest way for improve : use "my $WIDTH = 4;" beside "my $WIDTH = 32;" in "sub b2h" Result after fix: phash: GD : AB802A1820002000 1010101110000000001010100001100000100000000000000010000000000000 ImageMagick : AB80221808200020 1010101110000000001000100001100000001000001000000000000000100000 ( this char "0" was lost before fix ==> ImageMagick : AB802218-->0<--8200020 1010101110000000001000100001100000001000001000000000000000100000 ) please check it and fix if posible. thanks --- With Best Regards, Igor.

Fri Jun 12 07:13:29 2015 runarb [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #105168] Bug in Image::Hash b2h subprogramm
Date:	Fri, 12 Jun 2015 13:13:12 +0200
To:	bug-Image-Hash [...] rt.cpan.org
From:	Runar Buvik <runarb [...] gmail.com>

Hi Thank you for informing me about this. I am currently on vacation, but will investigate as soone I get back to the office. Best regards Runar Buvik On Thu, Jun 11, 2015 at 8:56 AM, Igor . via RT <bug-Image-Hash@rt.cpan.org> wrote: Show quoted text

> Thu Jun 11 02:56:37 2015: Request 105168 was acted upon. > Transaction: Ticket created by disop2004@mail.ru > Queue: Image-Hash > Subject: Bug in Image::Hash b2h subprogramm > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: disop2004@mail.ru > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=105168 > > > > > hello Runar Buvik. > > thanks for usefull util "Image::Hash" , but it have some bug. > > testing system: Win x64 ; perl 5, version 14, subversion 2 (v5.14.2) built > for MSWin32-x64-multi-thread (ActiveState Perl) > > Bug found while testing included image print-hashes-for-files.pl > "images/FishEyeViewofAtlantis.jpg" > > phash: > GD : AB802A1820002000 > 1010101110000000001010100001100000100000000000000010000000000000 > ImageMagick : AB8022188200020 > 1010101110000000001000100001100000001000001000000000000000100000 > > Bug: HEX LENGTH - is different ! ( length AB802A1820002000 vs length > AB8022188200020 ) (with equal binary length) . trouble with sub "b2h". > > simplest way for improve : use "my $WIDTH = 4;" beside "my $WIDTH = > 32;" in "sub b2h" > > Result after fix: > phash: > GD : > AB802A1820002000 1010101110000000001010100001100000100000000000000010000000000000 > ImageMagick : AB80221808200020 > 1010101110000000001000100001100000001000001000000000000000100000 > ( this char "0" was lost before fix ==> ImageMagick : > AB802218-->0<--8200020 > 1010101110000000001000100001100000001000001000000000000000100000 ) > > please check it and fix if posible. > thanks > --- > With Best Regards, Igor. > >

Fri Jun 12 07:13:30 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Jul 28 10:28:41 2015 RUNARB [...] cpan.org - Correspondence added

Hi Igor Thank you for reporting this. I have implemented the fix you suggested in version 0.05. I have also added some more test to better test for this type of error in the future. Best regards Runar Buvik

Tue Jul 28 10:28:43 2015 RUNARB [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Jul 28 10:28:49 2015 RUNARB [...] cpan.org - Fixed in 0.05 added