Bug #105061 for Text-CSV_XS: test failures with unicode

Sun Jun 07 20:10:32 2015 maurice [...] cpan.org - Ticket created

Subject:

test failures with unicode

$ perl -v This is perl 5, version 18, subversion 1 (v5.18.1) built for x86_64-linux $ export PERL_UNICODE=SDAL $ cpanm Text::CSV_XS --> Working on Text::CSV_XS Fetching http://www.cpan.org/authors/id/H/HM/HMBRAND/Text-CSV_XS-1.18.tgz ... OK Configuring Text-CSV_XS-1.18 ... OK Building and testing Text-CSV_XS-1.18 ... FAIL ! Installing Text::CSV_XS failed. See /home/mla/.cpanm/work/1433722016.21451/build.log for details. Retry with --force to force install it. $ unset PERL_UNICODE $ cpanm Text::CSV_XS --> Working on Text::CSV_XS Fetching http://www.cpan.org/authors/id/H/HM/HMBRAND/Text-CSV_XS-1.18.tgz ... OK Configuring Text-CSV_XS-1.18 ... OK Building and testing Text-CSV_XS-1.18 ... OK Successfully installed Text-CSV_XS-1.18 1 distribution installed

Mon Jun 08 02:50:05 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-06-07 20:10:32, MAURICE wrote: Show quoted text

> $ perl -v > This is perl 5, version 18, subversion 1 (v5.18.1) built for x86_64- > linux > > > $ export PERL_UNICODE=SDAL > $ cpanm Text::CSV_XS > --> Working on Text::CSV_XS > Fetching http://www.cpan.org/authors/id/H/HM/HMBRAND/Text-CSV_XS- > 1.18.tgz ... OK > Configuring Text-CSV_XS-1.18 ... OK > Building and testing Text-CSV_XS-1.18 ... FAIL > ! Installing Text::CSV_XS failed. See > /home/mla/.cpanm/work/1433722016.21451/build.log for details. Retry > with --force to force install it. > > > $ unset PERL_UNICODE > $ cpanm Text::CSV_XS > --> Working on Text::CSV_XS > Fetching http://www.cpan.org/authors/id/H/HM/HMBRAND/Text-CSV_XS- > 1.18.tgz ... OK > Configuring Text-CSV_XS-1.18 ... OK > Building and testing Text-CSV_XS-1.18 ... OK > Successfully installed Text-CSV_XS-1.18 > 1 distribution installed

I think that PERL_UNICODE should not be set when installing CPAN modules. In fact, I think that PERL_UNICODE should never be set, and instead the scripts/modules itself should be fixed to deal correctly with unicode.

Mon Jun 08 02:50:05 2015 The RT System itself - Status changed from 'new' to 'open'

Mon Jun 08 03:00:58 2015 maurice [...] cpan.org - Correspondence added

On Mon Jun 08 02:50:05 2015, SREZIC wrote: Show quoted text

> I think that PERL_UNICODE should not be set when installing CPAN > modules. In fact, I think that PERL_UNICODE should never be set, and > instead the scripts/modules itself should be fixed to deal correctly > with unicode.

So from that perspective, the build tools should start with an undefined PERL_UNICODE then, no?

Mon Jun 08 08:31:15 2015 HMBRAND [...] cpan.org - Correspondence added

Yes, they should. It is impossible to reset/ignore PERL_UNICODE fro the testfiles, so I have hardened the tests against this "stupidity". It worries me that this is the first report that detected this in 17 years. Patched. Will not fail in 1.19 FWIW open $fh, "<:raw", $file; is unsupported in 5.6.x open $fh, "<:raw", \$str; is unsupported in 5.8.x

Mon Jun 08 08:31:17 2015 HMBRAND [...] cpan.org - Status changed from 'open' to 'patched'

Wed Jun 17 09:44:21 2015 HMBRAND [...] cpan.org - Fixed in 1.19 added

Wed Jun 17 09:44:22 2015 HMBRAND [...] cpan.org - Broken in 0.18 deleted

Wed Jun 17 09:44:22 2015 HMBRAND [...] cpan.org - Correspondence added

Though this is a bug in the toolchain, Text::CSV_XS' test suite now has means to avoid this

Wed Jun 17 09:44:24 2015 HMBRAND [...] cpan.org - Status changed from 'patched' to 'resolved'