Skip Menu |

This queue is for tickets about the Math-NumSeq-Alpha CPAN distribution.

Report information
The Basics
Id: 104832
Status: resolved
Priority: 0/
Queue: Math-NumSeq-Alpha

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2
Fixed in: 3



Subject: (Smartmatch|when|given) is experimental
Newer perls have new warning related to smartmatch stuff, which may lead to test failures. See http://www.cpantesters.org/cpan/report/351bd3ea-d3d3-11e3-a7b3-a661eea79835 for a sample fail report.
Subject: Re: [rt.cpan.org #104832] (Smartmatch|when|given) is experimental
Date: Mon, 01 Jun 2015 18:36:18 +1000
To: "Slaven_Rezic via RT" <bug-Math-NumSeq-Alpha [...] rt.cpan.org>
From: Kevin Ryde <user42_kevin [...] yahoo.com.au>
"Slaven_Rezic via RT" <bug-Math-NumSeq-Alpha@rt.cpan.org> writes: Show quoted text
> > Newer perls have new warning related to smartmatch stuff,
By warning I take it you mean breaking code which used a documented feature as soon as it was documented. :-) Show quoted text
> which may > lead to test failures. See > http://www.cpantesters.org/cpan/report/351bd3ea-d3d3-11e3-a7b3-a661eea79835 > for a sample fail report.
I think the blame lies with Lingua::POL::Numbers and Lingua::UK::Numbers, which in turn I only get to via Lingua::Any::Numbers. (I can load before my warnings checker if you don't think it can be resolved at the source.) Dunno why Lingua::POL::Numbers isn't called Lingua::PL::Numbers. Isn't there a PL module already? Or that's the reason it's not called that. Lingua::UK::Numbers reads like it's for money rather than numbers as such. If so maybe Lingua::Any::Numbers would skip it, if it can divine its nature.
On 2015-06-01 04:36:49, user42_kevin@yahoo.com.au wrote: Show quoted text
> "Slaven_Rezic via RT" <bug-Math-NumSeq-Alpha@rt.cpan.org> writes:
> > > > Newer perls have new warning related to smartmatch stuff,
> > By warning I take it you mean breaking code which used a documented > feature as soon as it was documented. :-) >
> > which may > > lead to test failures. See > > http://www.cpantesters.org/cpan/report/351bd3ea-d3d3-11e3-a7b3- > > a661eea79835 > > for a sample fail report.
> > I think the blame lies with Lingua::POL::Numbers and > Lingua::UK::Numbers, which in turn I only get to via > Lingua::Any::Numbers. (I can load before my warnings checker if you > don't think it can be resolved at the source.) > > Dunno why Lingua::POL::Numbers isn't called Lingua::PL::Numbers. > Isn't > there a PL module already? Or that's the reason it's not called that. > > Lingua::UK::Numbers reads like it's for money rather than numbers as > such. If so maybe Lingua::Any::Numbers would skip it, if it can > divine > its nature.
Actually, the mentioned fail report is quite old, and both Lingua::POL::Numbers and Lingua::UK::Numbers are fixed and don't emit any warnings anymore. But Lingua::SWE::Numbers is still causing warnings (use of encoding pragma is deprecated). I wrote a bug report: https://rt.cpan.org/Ticket/Display.html?id=104855 For your module, I don't know what's the best approach for upstream warnings. Maybe you can wait for a couple of days if the remaining warning is fixed, and if it isn't, cease these specific warnings (e.g. by detecting the presence of the problematic module+version).
Subject: Re: [rt.cpan.org #104832] (Smartmatch|when|given) is experimental
Date: Tue, 02 Jun 2015 18:18:34 +1000
To: "Slaven_Rezic via RT" <bug-Math-NumSeq-Alpha [...] rt.cpan.org>
From: Kevin Ryde <user42_kevin [...] yahoo.com.au>
"Slaven_Rezic via RT" <bug-Math-NumSeq-Alpha@rt.cpan.org> writes: Show quoted text
> > For your module, I don't know what's the best approach for upstream > warnings. Maybe you can wait for a couple of days if the remaining > warning is fixed, and if it isn't, cease these specific warnings > (e.g. by detecting the presence of the problematic module+version).
I uploaded a version 3 with the lingua load raised before my warnings checks. The warnings are still printed but I don't take them as fatal, or that'll be the intention ... -- "It's a long way to the shop if you want a sausage roll."
On 2015-06-02 04:19:42, user42_kevin@yahoo.com.au wrote: Show quoted text
> "Slaven_Rezic via RT" <bug-Math-NumSeq-Alpha@rt.cpan.org> writes:
> > > > For your module, I don't know what's the best approach for upstream > > warnings. Maybe you can wait for a couple of days if the remaining > > warning is fixed, and if it isn't, cease these specific warnings > > (e.g. by detecting the presence of the problematic module+version).
> > I uploaded a version 3 with the lingua load raised before my warnings > checks. The warnings are still printed but I don't take them as fatal, > or that'll be the intention ... >
This looks good so far: http://matrix.cpantesters.org/?dist=Math-NumSeq-Alpha%203