Skip Menu |

This queue is for tickets about the Term-UI CPAN distribution.

Report information
The Basics
Id: 104688
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Term-UI

People
Owner: BINGOS [...] cpan.org
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.44
Fixed in: 0.46



Subject: t/02_ui.t fails without terminal because of wrong number of tests to skip
It's necessary to update number of t/02_ui.t tests to skip when a terminal is not available. Otherwise the tests does not match the test plan: $ prove </dev/null t/00_load.t ..... 1/? # Testing Term::UI 0.44 t/00_load.t ..... ok t/01_history.t .. ok t/02_ui.t ....... 1/22 # Looks like you planned 22 tests but ran 21. t/02_ui.t ....... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/22 subtests
From: ppisar [...] redhat.com
Dne Po 25.Květen.2015 10:10:02, ppisar napsal(a): Show quoted text
> It's necessary to update number of t/02_ui.t tests to skip when a > terminal is not available.
This patch fixes it. -- Petr
Subject: Term-UI-0.44-Correct-number-of-tests-to-skip-in-t-02_ui.t.patch
From 136bc1a7ab0672248aa5f87b033ccd9012e8a56a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Mon, 25 May 2015 16:04:39 +0200 Subject: [PATCH] Correct number of tests to skip in t/02_ui.t MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Running tests without terminal causes a failure because adding a new test for multiple choice forgot to increase the number of tests to skip when no terminal is available. CPAN RT#104688 Signed-off-by: Petr Písař <ppisar@redhat.com> --- t/02_ui.t | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/02_ui.t b/t/02_ui.t index c2afb35..4e80afc 100644 --- a/t/02_ui.t +++ b/t/02_ui.t @@ -14,7 +14,7 @@ $Term::UI::VERBOSE = $Term::UI::VERBOSE = 0; # SKIP tests if we aren't on a terminal SKIP: { -skip 'not on a terminal', 20 unless -t; +skip 'not on a terminal', 21 unless -t; ### enable warnings $^W = 1; -- 2.1.0
On Mon May 25 10:12:46 2015, ppisar wrote: Show quoted text
> Dne Po 25.Květen.2015 10:10:02, ppisar napsal(a):
> > It's necessary to update number of t/02_ui.t tests to skip when a > > terminal is not available.
> > This patch fixes it. > > -- Petr
Hi, thanks for spotting this and providing a patch. I applied this https://github.com/jib/term-ui/commit/edad887f6cc619f50217b13f4fffae1a06c99e3b and released 0.46 yesterday. Many thanks.