Bug #104686 for Net-SSLeay: [PATCH] Add X509_check

Mon May 25 08:17:01 2015 CGPAN [...] cpan.org - Ticket created

Subject:

[PATCH] Add X509_check_* functions from OpenSSL 1.0.2

This patch adds the X509_check_* functions introduced in OpenSSL 1.0.2. See https://www.openssl.org/docs/crypto/X509_check_host.html

Subject:

X509_check.patch

Message body is not shown because it is too large.

Tue May 26 02:07:09 2015 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #104686] [PATCH] Add X509_check_* functions from OpenSSL 1.0.2
Date:	Tue, 26 May 2015 16:06:50 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Thanks. your patch is now in SVN 438 and will appear in the next release. Cheers. On Monday, May 25, 2015 08:17:02 AM you wrote: Show quoted text

> Mon May 25 08:17:01 2015: Request 104686 was acted upon. > Transaction: Ticket created by CGPAN > Queue: Net-SSLeay > Subject: [PATCH] Add X509_check_* functions from OpenSSL 1.0.2 > Broken in: 1.68 > Severity: Wishlist > Owner: Nobody > Requestors: CGPAN@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=104686 > > > > This patch adds the X509_check_* functions introduced in OpenSSL 1.0.2. > > See https://www.openssl.org/docs/crypto/X509_check_host.html

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Tue May 26 02:07:10 2015 The RT System itself - Status changed from 'new' to 'open'

Tue May 26 09:04:08 2015 CGPAN [...] cpan.org - Correspondence added

Thanks! Please note that in the compatibility notes I referred to Net-SSLeay-1.xx because I didn't know in which version this would be included. Maybe you would like to update SSLeay.pod accordingly.

Tue May 26 17:52:49 2015 MIKEM [...] cpan.org - Correspondence added

Now in SVN 440 Will appear in the next release.

Tue May 26 17:52:52 2015 MIKEM [...] cpan.org - Status changed from 'open' to 'resolved'

Tue May 26 17:52:52 2015 MIKEM [...] cpan.org - Taken

Wed May 27 03:39:16 2015 CGPAN [...] cpan.org - Correspondence added

Sorry for reopening but I missed the fact that X509_check_ip() requires the address length because the address is in binary format. The patch attached addresses that (it's against SVN 440).

Subject:

X509_check_ip.patch

Index: SSLeay.xs =================================================================== --- SSLeay.xs (revision 440) +++ SSLeay.xs (working copy) @@ -2356,9 +2356,13 @@ RETVAL int -X509_check_ip(X509 *cert, const unsigned char *address, unsigned int flags = 0) +X509_check_ip(X509 *cert, SV *address, unsigned int flags = 0) + INIT: + unsigned char *c_address; + size_t addresslen; CODE: - RETVAL = X509_check_ip(cert, address, 0, flags); + c_address = SvPV(address, addresslen); + RETVAL = X509_check_ip(cert, c_address, addresslen, flags); OUTPUT: RETVAL

Wed May 27 03:39:17 2015 CGPAN [...] cpan.org - Status changed from 'resolved' to 'open'

Wed May 27 19:03:25 2015 mikem [...] airspayce.com - Correspondence added

Subject:	Re: [rt.cpan.org #104686] [PATCH] Add X509_check_* functions from OpenSSL 1.0.2
Date:	Thu, 28 May 2015 09:03:13 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] airspayce.com>

Hi, Done in SVN 441. Thanks. Cheers. On Wednesday, May 27, 2015 03:39:17 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=104686 > > > Sorry for reopening but I missed the fact that X509_check_ip() requires the > address length because the address is in binary format. > > The patch attached addresses that (it's against SVN 440).

-- Mike McCauley VK4AMM mikem@airspayce.com Airspayce Pty Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.airspayce.com Phone +61 7 5598-7474

Sun Jul 08 07:05:09 2018 chrisn [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Jul 08 07:05:10 2018 chrisn [...] cpan.org - Fixed in 1.69 added

Bug #104686 for Net-SSLeay: [PATCH] Add X509_check_* functions from OpenSSL 1.0.2