Skip Menu |

This queue is for tickets about the XML-LibXML CPAN distribution.

Report information
The Basics
Id: 104666
Status: open
Priority: 0/
Queue: XML-LibXML

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 2.0121
Fixed in: (no value)



Subject: Cygwin: enable memory test
Please treat Cygwin like Linux whenever possible.
Subject: perl-XML-LibXML.src.patch
--- origsrc/XML-LibXML-2.0121/t/11memory.t 2012-08-09 09:31:14.000000000 +0200 +++ src/XML-LibXML-2.0121/t/11memory.t 2015-05-23 22:14:20.301252900 +0200 @@ -7,7 +7,7 @@ use TestHelpers; use Test::More; use constant TIMES_THROUGH => $ENV{MEMORY_TIMES} || 100_000; -if ($^O ne 'linux') +if (($^O ne 'linux') and not ($^O eq 'cygwin')) { plan skip_all => 'linux platform only.'; }
On 2015-05-24 07:34:12, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> Please treat Cygwin like Linux whenever possible.
Why not simply: if (($^O ne 'linux') and ($^O ne 'cygwin')) And probably the skip message should be adjusted, too.
On Mon May 25 04:03:36 2015, SREZIC wrote: Show quoted text
> On 2015-05-24 07:34:12, > https://me.yahoo.com/howdidwegetherereally#f714d wrote:
> > Please treat Cygwin like Linux whenever possible.
> > Why not simply: > > if (($^O ne 'linux') and ($^O ne 'cygwin')) > > And probably the skip message should be adjusted, too.
That should work. :-)
On Tue May 26 16:08:42 2015, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> On Mon May 25 04:03:36 2015, SREZIC wrote:
> > On 2015-05-24 07:34:12, > > https://me.yahoo.com/howdidwegetherereally#f714d wrote:
> > > Please treat Cygwin like Linux whenever possible.
> > > > Why not simply: > > > > if (($^O ne 'linux') and ($^O ne 'cygwin')) > > > > And probably the skip message should be adjusted, too.
> > That should work. :-)
This is fixed in revision 1427:b73be7040551c1f2c98cc3bcd2e953f7683bbef2 in the repository and will be on CPAN in the next release. Thanks for the report.
On Fri May 29 03:36:56 2015, SHLOMIF wrote: Show quoted text
> This is fixed in revision > > 1427:b73be7040551c1f2c98cc3bcd2e953f7683bbef2 in the repository and > will be on CPAN in the next release. Thanks for the report.
Thank you.