Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 104657
Status: resolved
Priority: 0/
Queue: Net-DNS

People
Owner: Nobody in particular
Requestors:
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.83
Fixed in: (no value)



Subject: wrong split on Cygwin
On Cygwin the list of nameservers can be comma or space separated.
Subject: perl-Net-DNS.src.patch
--- origsrc/Net-DNS-0.83/lib/Net/DNS/Resolver/cygwin.pm 2015-02-26 16:01:55.000000000 +0100 +++ src/Net-DNS-0.83/lib/Net/DNS/Resolver/cygwin.pm 2015-05-23 22:44:54.164116200 +0200 @@ -106,7 +106,7 @@ sub init { getregkey( $interfaces, $iface, 'NameServer' ), getregkey( $interfaces, $iface, 'DhcpNameServer' ) ) { - push @nameservers, split; + push @nameservers, split /[ ,]/; last; } }
On 2015-05-24 03:50:33, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> On Cygwin the list of nameservers can be comma or space separated.
Could you paste a sample output? Also, this should have an accompanying test.
From: rwfranks [...] acm.org
On Sun May 24 06:50:33 2015, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> On Cygwin the list of nameservers can be comma or space separated.
Can you support that assertion by pointing at some documentation? Where did the comma-separated list originate?
On Mon May 25 08:17:29 2015, rwfranks@acm.org wrote: Show quoted text
> On Sun May 24 06:50:33 2015, > https://me.yahoo.com/howdidwegetherereally#f714d wrote:
> > On Cygwin the list of nameservers can be comma or space separated.
> > Can you support that assertion by pointing at some documentation?
No, that's just what I got back from the call. Show quoted text
> Where did the comma-separated list originate?
I don't really know, but I believe that it's from DHCP. It only happens on a corporate network so far.
On Sun May 24 15:25:50 2015, ETHER wrote: Show quoted text
> On 2015-05-24 03:50:33, > https://me.yahoo.com/howdidwegetherereally#f714d wrote:
> > On Cygwin the list of nameservers can be comma or space separated.
> > Could you paste a sample output?
The string I got back was simply two numerical IPv4 addresses separated by a comma, which then failed to resolve of course. The DNS servers on that network have no names and I believe that setup comes in via DHCPv4, but I can't say for sure.
On 2015-05-26 15:58:01, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> On Sun May 24 15:25:50 2015, ETHER wrote:
> > On 2015-05-24 03:50:33, > > https://me.yahoo.com/howdidwegetherereally#f714d wrote:
> > > On Cygwin the list of nameservers can be comma or space separated.
> > > > Could you paste a sample output?
> > The string I got back was simply two numerical IPv4 addresses > separated by a comma, which then failed to resolve of course. The DNS > servers on that network have no names and I believe that setup comes > in via DHCPv4, but I can't say for sure.
DNS servers never have names.
From: rwfranks [...] acm.org
On Tue May 26 15:58:01 2015, https://me.yahoo.com/howdidwegetherereally#f714d wrote: Show quoted text
> On Sun May 24 15:25:50 2015, ETHER wrote:
> > On 2015-05-24 03:50:33, > > https://me.yahoo.com/howdidwegetherereally#f714d wrote:
> > > On Cygwin the list of nameservers can be comma or space separated.
> > > > Could you paste a sample output?
> > The string I got back was simply two numerical IPv4 addresses > separated by a comma, which then failed to resolve of course. The DNS > servers on that network have no names and I believe that setup comes > in via DHCPv4, but I can't say for sure.
There seems to be no good definition of registry file syntax. From the scraps I dredged up, it seems that it may not even be consistent across all Windows versions. I note that the search list has been split on either space or commas since cygwin support appeared in 0.43 (2003). On the optimistic assumption that this is more widely applicable, I have applied that fix to all the splits. A dev release Net::DNS 1.00_01 was uploaded to CPAN this morning which should overcome the problem.
On Wed May 27 15:47:14 2015, rwfranks@acm.org wrote: Show quoted text
> There seems to be no good definition of registry file syntax. From > the scraps I dredged up, it seems that it may not even be consistent > across all Windows versions.
Well, it's supposed to be space separated but apaprently not always. I've looked it up in the registry again on my computer at work and currently it has a space as separator, but I'm both on a different computer and network in the meantime. Show quoted text
> I note that the search list has been split on either space or commas > since cygwin support appeared in 0.43 (2003). > > On the optimistic assumption that this is more widely applicable, I > have applied that fix to all the splits. > > A dev release Net::DNS 1.00_01 was uploaded to CPAN this morning which > should overcome the problem.
I can't tell how it would work with a comma since my build system has only a single entry in DhcpNameServer, but I built and tested 1.00_01 just fine on perl-5.22.0-RC2 on Cygwin. Will this become a normal release shortly? I'll build a new Perl for Cygwin plus all the distributions for Cygwin some time next week.
On Fri 29 Mei 2015 17:13:32, https://me.yahoo.com> I can't tell how it would work with a comma since my build system has Show quoted text
> only a single entry in DhcpNameServer, but I built and tested 1.00_01 > just fine on perl-5.22.0-RC2 on Cygwin. Will this become a normal > release shortly? I'll build a new Perl for Cygwin plus all the > distributions for Cygwin some time next week.
A little too late for your build, but the 1.01 release will follow very shortly now (likely within 1 week).
On Mon Jun 29 09:16:49 2015, NLNETLABS wrote: Show quoted text
> A little too late for your build, but the 1.01 release will follow > very shortly now (likely within 1 week).
Still in time, thank you very much. Since there are literally hundreds of CPAN packages to update or rebuild and not all of them are maintained by myself, this takes quite a while.