Bug #104640 for DestructAssign: Setting CCFLAGS considered harmful

Sat May 23 06:07:12 2015 ANDK [...] cpan.org - Ticket created

Subject:

Setting CCFLAGS considered harmful

In the last three months some of my smokers produced three fail reports against DestructAssign-0.002003, e.g.: http://www.cpantesters.org/cpan/report/e343ab62-ff21-11e4-b57d-faddf292232d Now I have investigated and found the culprit. It is the CCFLAGS => '-std=gnu99' setting in the Makefile.PL. See more insights at https://rt.perl.org/Ticket/Display.html?id=125236 and if you have questions, join the discussion over there. There are so many workarounds I could come up with but I do not know which is the correct one, so I refrain from suggesting a solution. HTH&&Thanks, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)

Sat May 23 12:43:20 2015 CINDY [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #104640] Setting CCFLAGS considered harmful
Date:	Sun, 24 May 2015 00:42:43 +0800
To:	bug-DestructAssign [...] rt.cpan.org
From:	"Cindy Wang (CindyLinz)" <cindy [...] cpan.org>

Thank you for mentioning me about the handshake problem~ The flag '-std=gnu99' changes some of the C syntax and is not easy to remove.. /_\ I think the problem should not be relative to this flag. I might need to collect more reports @@" On Sat, May 23, 2015 at 6:07 PM, Andreas Koenig via RT < bug-DestructAssign@rt.cpan.org> wrote: Show quoted text

> Sat May 23 06:07:12 2015: Request 104640 was acted upon. > Transaction: Ticket created by ANDK > Queue: DestructAssign > Subject: Setting CCFLAGS considered harmful > Broken in: 0.002003 > Severity: (no value) > Owner: Nobody > Requestors: ANDK@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=104640 > > > > In the last three months some of my smokers produced three fail reports > against DestructAssign-0.002003, e.g.: > > http://www.cpantesters.org/cpan/report/e343ab62-ff21-11e4-b57d-faddf292232d > > Now I have investigated and found the culprit. It is the CCFLAGS => > '-std=gnu99' setting in the Makefile.PL. See more insights at > https://rt.perl.org/Ticket/Display.html?id=125236 and if you have > questions, join the discussion over there. > > There are so many workarounds I could come up with but I do not know which > is the correct one, so I refrain from suggesting a solution. > > HTH&&Thanks, > (Disclaimer: this was discovered by statistical analysis, I'm not speaking > as a user) >

Sat May 23 12:43:27 2015 The RT System itself - Status changed from 'new' to 'open'

Sun May 24 15:39:35 2015 BULKDD [...] cpan.org - Correspondence added

On Sat May 23 12:43:20 2015, CINDY wrote: Show quoted text

> Thank you for mentioning me about the handshake problem~ > > The flag '-std=gnu99' changes some of the C syntax and is not easy to > remove.. /_\ > I think the problem should not be relative to this flag. > I might need to collect more reports @@" >

You can append to CCFLAGS but never delete the existing -D flags in it, but EUMM takes "the CCFLAGS" arg, not a string to append to it. Getting a copy of CCFLAGS to pass to EUMM is sometimes complicated, usually it is from $Config{ccflags}. You could also use the DEFINE parameter to EUMM which is empty by default by putting something like " DEFINE => '-DFOO -a1 -b2 -c3'," in the hash passed to WriteMakefile.

Mon May 25 03:48:00 2015 CINDY [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #104640] Setting CCFLAGS considered harmful
Date:	Mon, 25 May 2015 15:47:18 +0800
To:	bug-DestructAssign [...] rt.cpan.org
From:	"Cindy Wang (CindyLinz)" <cindy [...] cpan.org>

Hi~ ^^ I've uploaded a new version, 0.002004, to move '-std=gnu99' from CCFLAGS to DEFINE. I hope that will work ^^ The DEFINE hack is wise... though I feel a little uncomfortable ^^| Thank you~ On Mon, May 25, 2015 at 3:39 AM, Daniel Dragan via RT < bug-DestructAssign@rt.cpan.org> wrote: Show quoted text

> Queue: DestructAssign > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=104640 > > > On Sat May 23 12:43:20 2015, CINDY wrote:

> > Thank you for mentioning me about the handshake problem~ > > > > The flag '-std=gnu99' changes some of the C syntax and is not easy to > > remove.. /_\ > > I think the problem should not be relative to this flag. > > I might need to collect more reports @@" > >

> > You can append to CCFLAGS but never delete the existing -D flags in it, > but EUMM takes "the CCFLAGS" arg, not a string to append to it. Getting a > copy of CCFLAGS to pass to EUMM is sometimes complicated, usually it is > from $Config{ccflags}. You could also use the DEFINE parameter to EUMM > which is empty by default by putting something like " DEFINE => '-DFOO -a1 > -b2 -c3'," in the hash passed to WriteMakefile. > >

Sat Apr 16 08:38:45 2016 CINDY [...] cpan.org - Correspondence added

On Sat May 23 06:07:12 2015, ANDK wrote: Show quoted text

> In the last three months some of my smokers produced three fail > reports against DestructAssign-0.002003, e.g.: > > http://www.cpantesters.org/cpan/report/e343ab62-ff21-11e4-b57d- > faddf292232d > > Now I have investigated and found the culprit. It is the CCFLAGS => '- > std=gnu99' setting in the Makefile.PL. See more insights at > https://rt.perl.org/Ticket/Display.html?id=125236 and if you have > questions, join the discussion over there. > > There are so many workarounds I could come up with but I do not know > which is the correct one, so I refrain from suggesting a solution. > > HTH&&Thanks, > (Disclaimer: this was discovered by statistical analysis, I'm not > speaking as a user)

Sat Apr 16 08:38:47 2016 CINDY [...] cpan.org - Status changed from 'open' to 'resolved'