Skip Menu |

This queue is for tickets about the Geo-Coder-Google CPAN distribution.

Report information
The Basics
Id: 104618
Status: resolved
Priority: 0/
Queue: Geo-Coder-Google
People
Owner: justin.d.hunter [...] gmail.com
Requestors: ksm [...] jobindex.dk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in:
  • 0.14_02
  • 0.15
Fixed in:
  • 0.15_01
  • 0.16

History Show all quoted text
  Fri May 22 04:56:14 2015 ksm [...] jobindex.dk - Ticket created
CC: Anders Nielsen <anielsen [...] jobindex.dk>
Subject: Geo::Coder::Google::V3 version 0.14_02 croaks on zero results
Date: Fri, 22 May 2015 10:55:53 +0200
To: bug-Geo-Coder-Google [...] rt.cpan.org
From: "Klaus S. Madsen" <ksm [...] jobindex.dk>
Hi, The newest development release of Geo::Coder::Google croaks if the address being looked up isn't found. Since the function already has a reasonable way to report this (returning either undef or the empty list), this is a bit of a suprise. The attached patch prevents croaking on the the status ZERO_RESULTS. -- Klaus S. Madsen, Udvikler, ksm@jobindex.dk Jobindex A/S, Holger Danskes Vej 91, 2000 Frederiksberg Tlf +45 38 32 33 55, Dir +45 38 32 33 70 http://www.jobindex.dk/

Message body is not shown because sender requested not to inline it.

  Fri May 22 05:32:09 2015 ksm [...] jobindex.dk - Correspondence added
Subject: [rt.cpan.org #104618] Re: Geo::Coder::Google::V3 version 0.14_02 croaks on zero results
Date: Fri, 22 May 2015 11:31:58 +0200
To: bug-Geo-Coder-Google [...] rt.cpan.org
From: "Klaus S. Madsen" <ksm [...] jobindex.dk>
Sorry, This isn't an issue with the newest development release. It appears to have been the case since 0.11_03. https://github.com/arcanez/geo-coder-google/commit/95b26f3837f024f94c636fa22277ca4f63bebdb4 It might be that Google have changed the API to return the ZERO_RESULTS error after that commit was created? Never the less, I still believe that it the module shouldn't croak on ZERO_RESULTS. Klaus S. Madsen, Udvikler, ksm@jobindex.dk Jobindex A/S, Holger Danskes Vej 91, 2000 Frederiksberg Tlf +45 38 32 33 55, Dir +45 38 32 33 70 http://www.jobindex.dk/ On 2015-05-22 10:55, Klaus S. Madsen wrote: Show quoted text
> Hi, > > The newest development release of Geo::Coder::Google croaks if the > address being looked up isn't found. > > Since the function already has a reasonable way to report this > (returning either undef or the empty list), this is a bit of a suprise. > > The attached patch prevents croaking on the the status ZERO_RESULTS. >
  Fri May 22 12:53:02 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-05-22 04:56:14, ksm@jobindex.dk wrote: Show quoted text
> Hi, > > The newest development release of Geo::Coder::Google croaks if the > address being looked up isn't found. > > Since the function already has a reasonable way to report this > (returning either undef or the empty list), this is a bit of a suprise.
Just a side note: Geo::Coder::Googlev3 does not croak on ZERO_RESULTS, but returns undef or an empty list.
  Fri May 22 12:53:03 2015 The RT System itself - Status changed from 'new' to 'open'
  Tue Aug 04 20:58:11 2015 justin.d.hunter [...] gmail.com - Status changed from 'open' to 'patched'
  Tue Aug 04 20:58:21 2015 justin.d.hunter [...] gmail.com - Broken in 0.14_02 added
  Tue Aug 04 20:58:22 2015 justin.d.hunter [...] gmail.com - Broken in 0.15 added
  Wed Aug 12 14:19:50 2015 justin.d.hunter [...] gmail.com - Status changed from 'patched' to 'resolved'
  Wed Aug 12 14:19:50 2015 justin.d.hunter [...] gmail.com - Taken
  Wed Aug 12 14:19:51 2015 justin.d.hunter [...] gmail.com - Fixed in 0.15_01 added
  Wed Aug 12 14:19:51 2015 justin.d.hunter [...] gmail.com - Fixed in 0.16 added