Bug #104509 for PAR: Problem signing PAR file

Mon May 18 19:15:21 2015 ddcaspi [...] gmail.com - Ticket created

Subject:	Problem signing PAR file
Date:	Mon, 18 May 2015 18:14:50 -0500
To:	bug-par [...] rt.cpan.org
From:	Daniel Caspi <ddcaspi [...] gmail.com>

When including an additional module, it appears that it is not added to the MANIFEST and thus the -s option for signing fails. Here is an example of the flags I've used that causes the failure. -a '/usr/local/lib/perl5/site_perl/5.18.2/MIME/types.db;lib/MIME/types.db' -F PatchContent=MIME/Types.pm

Mon May 18 19:24:29 2015 SLAFFAN [...] cpan.org - Correspondence added

A possible patch for this is at https://github.com/shawnlaffan/perl_par_reinstate_cache/commit/6cad3a0562aca287834a8b926ce2ed3f9b7552e1 Shawn. On Mon May 18 19:15:21 2015, ddcaspi@gmail.com wrote: Show quoted text

> When including an additional module, it appears that it is not added to the > MANIFEST and thus the -s option for signing fails. > > Here is an example of the flags I've used that causes the failure. > > -a '/usr/local/lib/perl5/site_perl/5.18.2/MIME/types.db;lib/MIME/types.db' > -F PatchContent=MIME/Types.pm

Mon May 18 19:24:30 2015 The RT System itself - Status changed from 'new' to 'open'

Mon May 18 19:37:04 2015 ddcaspi [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #104509] Problem signing PAR file
Date:	Mon, 18 May 2015 18:36:34 -0500
To:	bug-PAR [...] rt.cpan.org
From:	Daniel Caspi <ddcaspi [...] gmail.com>

Thanks Shawn for this patch. I think it fixed that issue, but now I see the failure message below. I can't tell if something is wrong with my Module::Signature or not. Died at /usr/local/lib/perl5/site_perl/5.18.2/Module/Signature.pm line 498. On Mon, May 18, 2015 at 6:24 PM, Shawn Laffan via RT <bug-PAR@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=104509 > > > A possible patch for this is at > https://github.com/shawnlaffan/perl_par_reinstate_cache/commit/6cad3a0562aca287834a8b926ce2ed3f9b7552e1 > > Shawn. > > > On Mon May 18 19:15:21 2015, ddcaspi@gmail.com wrote:

> > When including an additional module, it appears that it is not added to

> the

> > MANIFEST and thus the -s option for signing fails. > > > > Here is an example of the flags I've used that causes the failure. > > > > -a

> '/usr/local/lib/perl5/site_perl/5.18.2/MIME/types.db;lib/MIME/types.db'

> > -F PatchContent=MIME/Types.pm

> > > >

Mon May 18 19:47:11 2015 SLAFFAN [...] cpan.org - Correspondence added

Unfortunately I can't help with Module::Signature as I've never used it. Maybe someone else can, but this is the PAR issue queue. Module::Signature has had a new release in the last few hours. If that does not fix things then perhaps submit a request on its issue tracker? https://rt.cpan.org/Dist/Display.html?Name=Module-Signature It's also safer to not run updates on the system perl. Try perlbrew or similar. http://perlbrew.pl/ Shawn. On Mon May 18 19:37:04 2015, ddcaspi@gmail.com wrote: Show quoted text

> Thanks Shawn for this patch. I think it fixed that issue, but now I > see the > failure message below. > I can't tell if something is wrong with my Module::Signature or not. > > Died at /usr/local/lib/perl5/site_perl/5.18.2/Module/Signature.pm line > 498. > > On Mon, May 18, 2015 at 6:24 PM, Shawn Laffan via RT <bug- > PAR@rt.cpan.org> > wrote: >

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=104509 > > > > > A possible patch for this is at > > https://github.com/shawnlaffan/perl_par_reinstate_cache/commit/6cad3a0562aca287834a8b926ce2ed3f9b7552e1 > > > > Shawn. > > > > > > On Mon May 18 19:15:21 2015, ddcaspi@gmail.com wrote:

> > > When including an additional module, it appears that it is not > > > added to

> > the

> > > MANIFEST and thus the -s option for signing fails. > > > > > > Here is an example of the flags I've used that causes the failure. > > > > > > -a

> > '/usr/local/lib/perl5/site_perl/5.18.2/MIME/types.db;lib/MIME/types.db'

> > > -F PatchContent=MIME/Types.pm

> > > > > > > >

Tue May 19 02:38:18 2015 RSCHUPP [...] cpan.org - Correspondence added

Am 2015-05-18 19:15:21, ddcaspi@gmail.com schrieb: Show quoted text

> Here is an example of the flags I've used that causes the failure. > > -a '/usr/local/lib/perl5/site_perl/5.18.2/MIME/types.db;lib/MIME/types.db' > -F PatchContent=MIME/Types.pm

Hi Daniel, thisn't about to your signing problem - I guess you needed this particular "-a" option because MIME/types.db didn't get packed automagically when use'ing MIME::Types? If so, please submit a bug in queue Module-ScanDeps about that. Cheers, Roderich

Tue May 19 10:22:38 2015 ddcaspi [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #104509] Problem signing PAR file
Date:	Tue, 19 May 2015 09:22:02 -0500
To:	bug-PAR [...] rt.cpan.org
From:	Daniel Caspi <ddcaspi [...] gmail.com>

Thanks Roderich. There's already a bug ticket in for that in ScanDeps from 2013. https://rt.cpan.org/Public/Bug/Display.html?id=91530 On Tue, May 19, 2015 at 1:38 AM, Roderich Schupp via RT <bug-PAR@rt.cpan.org Show quoted text

> wrote:

Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=104509 > > > Am 2015-05-18 19:15:21, ddcaspi@gmail.com schrieb:

> > Here is an example of the flags I've used that causes the failure. > > > > -a

> '/usr/local/lib/perl5/site_perl/5.18.2/MIME/types.db;lib/MIME/types.db'

> > -F PatchContent=MIME/Types.pm

> > Hi Daniel, > > thisn't about to your signing problem - I guess you needed this > particular "-a" option because MIME/types.db didn't get packed > automagically when use'ing MIME::Types? If so, please submit > a bug in queue Module-ScanDeps about that. > > Cheers, Roderich > > > >

Tue May 19 11:12:38 2015 RSCHUPP [...] cpan.org - Correspondence added

Am 2015-05-19 10:22:38, ddcaspi@gmail.com schrieb: Show quoted text

> There's already a bug ticket in for that in ScanDeps from 2013. > > https://rt.cpan.org/Public/Bug/Display.html?id=91530

Re-reading my own comments... Yeah, there are 1001 ways to refer to a data file from a Perl module. And most of them break when using PAR. The power of TMTOWTDI, yech. (In my dreams I envision there would be only one sanctioned method to do this and it could be inspected or intercepted by PAR.) This can't be fixed solely in Module::ScanDeps, it also needs a rule in PAR::Filter::PatchContent, cf. what's been done for Mozilla::CA. Cheers, Roderich

Tue May 19 11:21:23 2015 ddcaspi [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #104509] Problem signing PAR file
Date:	Tue, 19 May 2015 10:20:47 -0500
To:	bug-PAR [...] rt.cpan.org
From:	Daniel Caspi <ddcaspi [...] gmail.com>

Hey Roderich, Understood on that! What about compiling a list of 'problematic modules' and giving PAR the option to fix them? It might be a nice addition to the platform. The Encode module is another tricky one. It has many dependencies but they are only called when needed and so do not get appropriately packaged. In the meantime, the MANIFEST fix for the addfiles by Shawn is working and should probably be included as a fix, but I'm still not having luck with the Signature module for some reason. On Tue, May 19, 2015 at 10:12 AM, Roderich Schupp via RT < bug-PAR@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=104509 > > > Am 2015-05-19 10:22:38, ddcaspi@gmail.com schrieb:

> > There's already a bug ticket in for that in ScanDeps from 2013. > > > > https://rt.cpan.org/Public/Bug/Display.html?id=91530

> > Re-reading my own comments... > Yeah, there are 1001 ways to refer to a data file from a Perl module. > And most of them break when using PAR. The power of TMTOWTDI, yech. > (In my dreams I envision there would be only one sanctioned method > to do this and it could be inspected or intercepted by PAR.) > > This can't be fixed solely in Module::ScanDeps, it also needs a rule > in PAR::Filter::PatchContent, cf. what's been done for Mozilla::CA. > > Cheers, Roderich > >

Tue May 19 11:35:59 2015 RSCHUPP [...] cpan.org - Correspondence added

Am 2015-05-19 11:21:23, ddcaspi@gmail.com schrieb: Show quoted text

> What about compiling a list of 'problematic modules' and giving PAR the > option to fix them?

This list already exists, actually in two parts: one is the %Preload hash in Module::ScanDeps, the other is PAR::Filter::PatchContent. The latter is sparingly used as it is very brittle: though it typically patches only a single in a module, it will stop working when the module author modifies this line. Cheers, Roderich

Thu May 28 01:19:05 2015 ddcaspi [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #104509] Problem signing PAR file
Date:	Thu, 28 May 2015 00:18:36 -0500
To:	bug-PAR [...] rt.cpan.org
From:	Daniel Caspi <ddcaspi [...] gmail.com>

Thanks Roderich, That's helpful to know. FYI .. looks like my issue with the Module::Signature is more general than PAR, it failed on some very basic tests even with the latest version with cpansign. I've submitted a bug report. The MANIFEST addition fix should resolve this issue with PAR, and hopefully the other one will get resolved as well. Thanks, Dan On Tue, May 19, 2015 at 10:36 AM, Roderich Schupp via RT < bug-PAR@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=104509 > > > Am 2015-05-19 11:21:23, ddcaspi@gmail.com schrieb:

> > What about compiling a list of 'problematic modules' and giving PAR the > > option to fix them?

> > This list already exists, actually in two parts: > one is the %Preload hash in Module::ScanDeps, the other is > PAR::Filter::PatchContent. The latter is sparingly used as > it is very brittle: though it typically patches only a single > in a module, it will stop working when the module author > modifies this line. > > Cheers, Roderich > > >

Mon Jul 06 07:21:52 2015 RSCHUPP [...] cpan.org - Correspondence added

Fixed, see RT#104560. Cheers, Roderich

Mon Jul 06 07:21:59 2015 RSCHUPP [...] cpan.org - Status changed from 'open' to 'resolved'