Skip Menu |

This queue is for tickets about the Encode-Locale CPAN distribution.

Report information
The Basics
Id: 104348
Status: resolved
Priority: 0/
Queue: Encode-Locale

People
Owner: Nobody in particular
Requestors: matsp888 [...] yahoo.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Incorrect use of GetConsoleCP() to get ANSI code page
Date: Mon, 11 May 2015 13:22:54 +0000 (UTC)
To: "bug-Encode-Locale [...] rt.cpan.org" <bug-Encode-Locale [...] rt.cpan.org>
From: Mats Peterson <matsp888 [...] yahoo.com>
I'm running ActivePerl 5.20.2 in Windows XP Pro, and it uses Encode::Locale 1.04. The $Encode::Locale::ENCODING_LOCALE_FS incorrectly holds an OEM code page (cp437 in my case) rather than an ANSI one like cp1252. I have noticed that you have removed the call to GetACP() in 1.04 and replaced it with GetConsoleCP(), which isn't the correct way to get the ANSI code page, since the console input code page can be anything, most probably an OEM one though. GetACP() should be used just like before. Regards, Mats Peterson  -- Mats Peterson http://matsp888.no-ip.org/~mats/
I've now uploaded 1.05 with this patch.