Skip Menu |

This queue is for tickets about the Net-CUPS CPAN distribution.

Report information
The Basics
Id: 104237
Status: resolved
Priority: 0/
Queue: Net-CUPS

People
Owner: Nobody in particular
Requestors: josh [...] nijenhuis.ca
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: CUPS 2.*
Date: Tue, 05 May 2015 12:42:10 -0400
To: bug-Net-CUPS [...] rt.cpan.org
From: Josh Nijenhuis <josh [...] nijenhuis.ca>
Here is the output from cpan -i Net::CUPS Net::CUPS Configuration Running cups-config ... 2.0.2 The version of the Common Unix Printing System installed on your system is too old for this module to work properly. Please upgrade the version of CUPS on your system to version 1.2.2 or higher and re-run Makefile.PL to install this module. most likely bad version check? Thanks, Josh
Subject: [rt.cpan.org #104237]
Date: Tue, 27 Oct 2015 13:23:47 +0100
To: bug-Net-CUPS [...] rt.cpan.org
From: Mathieu Simon <mathieu.simon [...] simweb.ch>
Hi This attached fix that nice but was tortured with a couple of version combinations to see if it was correct about for released and future CUPS versions. This only fixes the version check 0.6.1, there are other known issues such as reported in #78583 that require applying patches for more modern CUPS versions. -- Mathieu --- Makefile.PL.orig 2015-10-27 12:05:43 UTC +++ Makefile.PL @@ -31,8 +31,10 @@ else my @version_parts = split( /\./, $version ); -if( ( $version_parts[1] < 2 ) || - ( ( $version_parts[1] == 2 ) && ( $version_parts[2] < 2 ) ) ) +if( + ( $version_parts[0] < 1 ) || + ( ( $version_parts[0] == 1 ) && ( $version_parts[1] < 2 ) ) || + ( ( $version_parts[0] == 1 ) && ( $version_parts[1] == 2 ) && ( $version_parts[2] < 2 ) ) ) { print "The version of the Common Unix Printing System installed\n"; print "on your system is too old for this module to work properly.\n";
I am looking for someone to take over this module. I no longer have time to support it and haven't coded any Perl in years. I have posted this message to other bugs in the CPAN RT instance indicating the same. I hope someone can pick it up and provide great service! On Tue Oct 27 08:24:08 2015, mathieu.simon@simweb.ch wrote: Show quoted text
> Hi > > This attached fix that nice but was tortured with a couple of version > combinations to see if it was correct about for released and future CUPS > versions. > > This only fixes the version check 0.6.1, there are other known issues > such as reported in #78583 that require applying patches for more modern > CUPS versions. > > -- Mathieu > > --- Makefile.PL.orig 2015-10-27 12:05:43 UTC > +++ Makefile.PL > @@ -31,8 +31,10 @@ else > > my @version_parts = split( /\./, $version ); > > -if( ( $version_parts[1] < 2 ) || > - ( ( $version_parts[1] == 2 ) && ( $version_parts[2] < 2 ) ) ) > +if( > + ( $version_parts[0] < 1 ) || > + ( ( $version_parts[0] == 1 ) && ( $version_parts[1] < 2 ) ) || > + ( ( $version_parts[0] == 1 ) && ( $version_parts[1] == 2 ) && ( > $version_parts[2] < 2 ) ) ) > { > print "The version of the Common Unix Printing System installed\n"; > print "on your system is too old for this module to work properly.\n"; >
Applied Mathieu's patch and published it in version 0.62. Thanks for the patch!