Bug #104128 for IO-Async: Nonobvious error message to Stream->write when not in a Loop

Thu Apr 30 11:36:52 2015 leonerd-cpan [...] leonerd.org.uk - Ticket created

Subject:

Nonobvious error message to Stream->write when not in a Loop

$ perl -MIO::Async::Stream -E 'IO::Async::Stream->new_for_stdout->write("Hello, world")->get' Can't call method "new_future" on an undefined value at /home/leo/lib/perl5/IO/Async/Stream.pm line 838. -- Paul Evans

Mon Jun 01 09:33:00 2015 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Thu Apr 30 11:36:52 2015, PEVANS wrote: Show quoted text

> $ perl -MIO::Async::Stream -E 'IO::Async::Stream->new_for_stdout-

> >write("Hello, world")->get'

> Can't call method "new_future" on an undefined value at > /home/leo/lib/perl5/IO/Async/Stream.pm line 838.

Something of an improvement. Perhaps. $ perl -Mblib -MIO::Async::Stream -E 'IO::Async::Stream->new_for_stdout->write("Hello, world")->get' Cannot ->write data returning a Future to a Stream not in a Loop at -e line 1. -- Paul Evans

Subject:

rt104128.patch

=== modified file 'lib/IO/Async/Stream.pm' --- lib/IO/Async/Stream.pm 2015-04-17 19:43:46 +0000 +++ lib/IO/Async/Stream.pm 2015-06-01 13:32:34 +0000 @@ -835,7 +835,10 @@ if( defined wantarray ) { my $orig_on_flush = $on_flush; my $orig_on_error = $on_error; - $f = $self->loop->new_future; + + my $loop = $self->loop or + croak "Cannot ->write data returning a Future to a Stream not in a Loop"; + $f = $loop->new_future; $on_flush = sub { $f->done; $orig_on_flush->( @_ ) if $orig_on_flush;

Mon Jun 01 09:33:25 2015 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'

Mon Aug 03 08:29:21 2015 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Released -- Paul Evans

Mon Aug 03 08:29:23 2015 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Mon Aug 03 08:29:24 2015 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.68 added