Bug #103959 for Genealogy-Gedcom-Date: t/escape.t test started to fail with perl 5.21.4

Sat Apr 25 07:39:22 2015 SREZIC [...] cpan.org - Ticket created

Subject:

t/escape.t test started to fail with perl 5.21.4

With perl 5.21.4 .. 5.21.11 the t/escape.t test fails: # Start testing parse_approximate_date(...) # Start testing parse_date_period(...) # Failed test 'Testing: To 25 Dec 2011' # at t/escape.t line 230. # Failed test 'Testing: To @\#DGregorian@ 25 Dec 2011' # at t/escape.t line 230. # Looks like you failed 2 tests of 11. t/escape.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/11 subtests

Sun Apr 26 18:39:44 2015 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #103959] t/escape.t test started to fail with perl 5.21.4
Date:	Mon, 27 Apr 2015 08:41:16 +1000
To:	bug-Genealogy-Gedcom-Date [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Slaven Thanx for the report. That test is the only one in the file which references '-inf', which is suspicious. On 25/04/15 21:39, Slaven_Rezic via RT wrote: Show quoted text

> Sat Apr 25 07:39:22 2015: Request 103959 was acted upon. > Transaction: Ticket created by SREZIC > Queue: Genealogy-Gedcom-Date > Subject: t/escape.t test started to fail with perl 5.21.4 > Broken in: 1.08 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103959 > > > > With perl 5.21.4 .. 5.21.11 the t/escape.t test fails: > > # Start testing parse_approximate_date(...) > # Start testing parse_date_period(...) > > # Failed test 'Testing: To 25 Dec 2011' > # at t/escape.t line 230. > > # Failed test 'Testing: To @\#DGregorian@ 25 Dec 2011' > # at t/escape.t line 230. > # Looks like you failed 2 tests of 11. > t/escape.t .. > Dubious, test returned 2 (wstat 512, 0x200) > Failed 2/11 subtests >

-- Ron Savage - savage.net.au

Sun Apr 26 18:39:44 2015 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 27 13:56:52 2015 SREZIC [...] cpan.org - Correspondence added

In this case it's probably the following change (from perl5214delta.pod): Infinity and NaN (not-a-number) handling improved Floating point values are able to hold the special values infinity (also -infinity), and NaN (not-a-number). Now we more robustly recognize and propagate the value in computations, and on output normalize them to "Inf" and "NaN". On 2015-04-26 18:39:44, ron@savage.net.au wrote: Show quoted text

> Hi Slaven > > Thanx for the report. That test is the only one in the file which > references '-inf', which is suspicious. > > On 25/04/15 21:39, Slaven_Rezic via RT wrote:

> > Sat Apr 25 07:39:22 2015: Request 103959 was acted upon. > > Transaction: Ticket created by SREZIC > > Queue: Genealogy-Gedcom-Date > > Subject: t/escape.t test started to fail with perl 5.21.4 > > Broken in: 1.08 > > Severity: (no value) > > Owner: Nobody > > Requestors: SREZIC@cpan.org > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103959 > > > > > > > With perl 5.21.4 .. 5.21.11 the t/escape.t test fails: > > > > # Start testing parse_approximate_date(...) > > # Start testing parse_date_period(...) > > > > # Failed test 'Testing: To 25 Dec 2011' > > # at t/escape.t line 230. > > > > # Failed test 'Testing: To @\#DGregorian@ 25 Dec 2011' > > # at t/escape.t line 230. > > # Looks like you failed 2 tests of 11. > > t/escape.t .. > > Dubious, test returned 2 (wstat 512, 0x200) > > Failed 2/11 subtests > >

>

Mon Apr 27 18:52:41 2015 rjbs [...] cpan.org - Correspondence added

Yeah. All the gyrations you're doing for Inf and Infinity and inf and #1.Inf and so on should cease to be needed in 5.22, when Inf is Inf is Inf... ...but my naive attempt to make your normalize to either Inf or inf failed. Could you let me know if you have a way to sort this out? I'm sorry we're only finding this so late, but this is one of the few kinds of breakage I absolutely expect to occur in a few places with 5.22. Fixing the fragmented stringification of Inf is going to reveal places where it has been previously worked around. :( -- rjbs

Mon Apr 27 19:09:41 2015 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #103959] t/escape.t test started to fail with perl 5.21.4
Date:	Tue, 28 Apr 2015 09:11:16 +1000
To:	bug-Genealogy-Gedcom-Date [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi On 28/04/15 08:52, Ricardo Signes via RT wrote: Show quoted text

> Queue: Genealogy-Gedcom-Date > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103959 > > > Yeah. All the gyrations you're doing for Inf and Infinity and inf and #1.Inf and so on should cease to be needed in 5.22, when Inf is Inf is Inf... > > ...but my naive attempt to make your normalize to either Inf or inf failed. Could you let me know if you have a way to sort this out? I'm sorry we're only finding this so late, but this is one of the few kinds of breakage I absolutely expect to occur in a few places with 5.22. Fixing the fragmented stringification of Inf is going to reveal places where it has been previously worked around. :(

Thanx for your interest. I'm using V 5.20.2 here and so don't see the problem. $work is deep in a CakePHP-based [*] project, but I have time to install V 5.21.11, which perlbrew tells me is available. Sigh. Just yesterday I upgraded to Debian 8, and it's not even Christmas. This does raise back-compat issues, but luckily reverse deps on MetaCPAN shows me no-one apart from myself is using this code (ostensibly), which is good. I'll investigate. [*] I must admit Cake very well designed, even though I love PHP's nickname of A Fractal of Bad Design: http://eev.ee/blog/2012/04/09/php-a-fractal-of-bad-design/ -- Ron Savage - savage.net.au

Tue Apr 28 01:55:35 2015 ANDK [...] cpan.org - Correspondence added

Xref in the bleadperl RT queue: https://rt.perl.org/Ticket/Display.html?id=124395

Tue Apr 28 02:12:24 2015 RSAVAGE [...] cpan.org - Correspondence added 30 min

This is fixed in V 1.10, which has been uploaded to CPAN. V 1.09 had the fix but erroneous metadata. It was tested under Perl V 5.21.11. Lastly, the module is now on github. See Changes for details. $many x $thanx for the report(s).

Tue Apr 28 02:12:26 2015 RSAVAGE [...] cpan.org - Status changed from 'open' to 'resolved'

Tue Apr 28 02:12:26 2015 RSAVAGE [...] cpan.org - Fixed in 1.08 added

Tue Apr 28 02:34:47 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-04-28 02:12:24, RSAVAGE wrote: Show quoted text

> This is fixed in V 1.10, which has been uploaded to CPAN. > > V 1.09 had the fix but erroneous metadata. > > It was tested under Perl V 5.21.11. > > Lastly, the module is now on github. > > See Changes for details. > > $many x $thanx for the report(s).

Unfortunately, now it works for 5.21.11 but is broken for older perl versions, at least on linux and freebsd: http://fast-matrix.cpantesters.org/?dist=Genealogy-Gedcom-Date%201.10

Tue Apr 28 02:34:48 2015 SREZIC [...] cpan.org - Status changed from 'resolved' to 'open'

Tue Apr 28 02:49:48 2015 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #103959] t/escape.t test started to fail with perl 5.21.4
Date:	Tue, 28 Apr 2015 16:51:29 +1000
To:	bug-Genealogy-Gedcom-Date [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Slaven On 28/04/15 16:34, Slaven_Rezic via RT wrote: Show quoted text

> Queue: Genealogy-Gedcom-Date > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103959 > > > On 2015-04-28 02:12:24, RSAVAGE wrote:

>> This is fixed in V 1.10, which has been uploaded to CPAN. >> >> V 1.09 had the fix but erroneous metadata. >> >> It was tested under Perl V 5.21.11. >> >> Lastly, the module is now on github. >> >> See Changes for details. >> >> $many x $thanx for the report(s).

> > Unfortunately, now it works for 5.21.11 but is broken for older perl versions, at least on linux and freebsd: http://fast-matrix.cpantesters.org/?dist=Genealogy-Gedcom-Date%201.10

Ah, yes, the back-compat stuff. Let me think about it. Case-insensitive compares are better than checking versions of Perl. -- Ron Savage - savage.net.au

Tue Apr 28 03:27:33 2015 RSAVAGE [...] cpan.org - Correspondence added 15 min

V 1.11 has been uploaded to CPAN. It was tested with Perls V 5.10.1, 5.20.2 and 5.21.11. Let's hope that is sufficient to lay this beast to rest.

Tue Apr 28 03:27:33 2015 RSAVAGE [...] cpan.org - Status changed from 'open' to 'resolved'