Bug #103885 for File-VirusScan: TMPDIR is not always /tmp

Wed Apr 22 14:51:16 2015 SREZIC [...] cpan.org - Ticket created

Subject:

TMPDIR is not always /tmp

This test error looks like it's expected that the temporary directory is /tmp. But a user may overwrite his temporary directory using the TMPDIR environment variable. Probably it's best to replace the filename pattern with just /.*/ # Failed test 'Error string is what we expected' # at t/file-virusscan-trivial.t line 49. # 'bogus scanner looking at /var/tmp/cpansmoker-1001/yApaYqyynW' # doesn't match '(?^:^bogus scanner looking at /tmp/(?:[A-Za-z0-9]+)$)' # Looks like you failed 1 test of 15. t/file-virusscan-trivial.t ........ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/15 subtests

Wed Apr 22 15:27:29 2015 dfs+pause [...] roaringpenguin.com - Taken

Wed Apr 22 15:29:58 2015 dfs [...] roaringpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #103885] TMPDIR is not always /tmp
Date:	Wed, 22 Apr 2015 15:29:38 -0400
To:	bug-File-VirusScan [...] rt.cpan.org
From:	Dianne Skoll <dfs [...] roaringpenguin.com>

Hi, Thanks for the bug report. I've applied the patch below in the git repository; the fix will be in the next release. Regards, Dianne. diff --git a/t/file-virusscan-trivial.t b/t/file-virusscan-trivial.t index 31874ef..1ba091b 100644 --- a/t/file-virusscan-trivial.t +++ b/t/file-virusscan-trivial.t @@ -46,5 +46,5 @@ $fh->close; $result = $s->scan( $filename ); isa_ok( $result, 'File::VirusScan::ResultSet'); ok( $result->has_error(), 'Result is an error' ); -like( ($result->get_error)[0]->get_data, qr{^bogus scanner looking at /tmp/(?:[A-Za-z0-9]+)$}, 'Error string is what we expected'); +like( ($result->get_error)[0]->get_data, qr{^bogus scanner looking at /.*/(?:[A-Za-z0-9]+)$}, 'Error string is what we expected'); 1;

Wed Apr 22 15:29:58 2015 The RT System itself - Status changed from 'new' to 'open'

Tue Apr 12 13:51:06 2016 SREZIC [...] cpan.org - Broken in 0.103 added