Skip Menu |

This queue is for tickets about the B-Flags CPAN distribution.

Report information
The Basics
Id: 103874
Status: resolved
Priority: 0/
Queue: B-Flags

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.11
Fixed in: (no value)



Subject: Compilation fails with perl 5.21.11 (op_lastsib)
Compilation fails with perl 5.21.11: cc -c -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -DVERSION=\"0.11\" -DXS_VERSION=\"0.11\" -fPIC "-I/opt/perl-5.21.11/lib/5.21.11/x86_64-linux/CORE" Flags.c Flags.xs: In function ‘XS_B__OP_flagspv’: Flags.xs:69:14: error: ‘OP’ has no member named ‘op_lastsib’
Subject: Re: [rt.cpan.org #103874] Compilation fails with perl 5.21.11 (op_lastsib)
Date: Thu, 23 Apr 2015 14:15:18 +0200
To: bug-B-Flags [...] rt.cpan.org
From: Reini Urban <rurban [...] cpan.org>
Thanks for the reminder. I already saw those changes, but I still need to find some time build a current perl. Not sure what to do about OP_PARENT yet. op_sibparent vs op_sibling. 2015-04-22 7:38 GMT+02:00 Slaven_Rezic via RT <bug-B-Flags@rt.cpan.org>: Show quoted text
> Wed Apr 22 01:38:46 2015: Request 103874 was acted upon. > Transaction: Ticket created by SREZIC > Queue: B-Flags > Subject: Compilation fails with perl 5.21.11 (op_lastsib) > Broken in: 0.11 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103874 > > > > Compilation fails with perl 5.21.11: > > cc -c -fwrapv -fno-strict-aliasing -pipe -fstack-protector -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2 -O2 -DVERSION=\"0.11\" -DXS_VERSION=\"0.11\" -fPIC "-I/opt/perl-5.21.11/lib/5.21.11/x86_64-linux/CORE" Flags.c > Flags.xs: In function ‘XS_B__OP_flagspv’: > Flags.xs:69:14: error: ‘OP’ has no member named ‘op_lastsib’ >
-- -- Reini
Le Jeu 23 Avr 2015 08:16:02, RURBAN a écrit : Show quoted text
> Thanks for the reminder. I already saw those changes, but I still need > to find some time build a current perl. > > Not sure what to do about OP_PARENT yet. op_sibparent vs op_sibling.
To have it work again, in the FreeBSD ports tree, I added the attached patch.
Subject: patch-Flags.xs
--- Flags.xs.orig 2014-12-03 12:04:54 UTC +++ Flags.xs @@ -66,8 +66,13 @@ flagspv(o) if (o->op_folded) sv_catpv(RETVAL, ",FOLDED"); #if (PERL_VERSION == 21 && PERL_SUBVERSION > 1) || PERL_VERSION >= 22 +#if (PERL_VERSION == 21 && PERL_SUBVERSION < 11) if (o->op_lastsib) sv_catpv(RETVAL, ",LASTSIB"); +#else + if (o->op_moresib) + sv_catpv(RETVAL, ",MORESIB"); +#endif #endif #endif #endif
Thanks, fixed with 0.12 -- Reini Urban
Note that I changed the LASTSIB|MORESIB flag to SIBLING only with 0.13 MORESIB is too low-level to me, SIBLING is now consistent for all perl versions, either indicating the existance of the pointer or the MORESIB flag. -- Reini Urban