Skip Menu |

This queue is for tickets about the POE CPAN distribution.

Report information
The Basics
Id: 103842
Status: resolved
Priority: 0/
Queue: POE

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc: abraxxa [...] cpan.org
ether [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.366
Fixed in: (no value)



Subject: yaml tests fail
POE's test suite fails with a fresh perl 5.21.11: # Failed test 'yaml without newlines dies when allowed' # at t/10_units/05_filters/51_reference_die.t line 45. # Failed test 'yaml without newlines returns error when caught' # at t/10_units/05_filters/51_reference_die.t line 50. # Looks like you failed 2 tests of 5. t/10_units/05_filters/51_reference_die.t ........... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/5 subtests This might be the same issue like in https://github.com/PerlDancer/Dancer/issues/1107
YAML.pm now Loads YAML without a trailing newline. This matches the other YAML implementations and the YAML spec. These tests can probably be removed. (I haven't actually looked at the tests). On a side note, I find it "interesting" that modules have tests for bad YAML. This change only relaxed the Load behaviour. On Mon Apr 20 19:08:17 2015, SREZIC wrote: Show quoted text
> POE's test suite fails with a fresh perl 5.21.11: > > # Failed test 'yaml without newlines dies when allowed' > # at t/10_units/05_filters/51_reference_die.t line 45. > > # Failed test 'yaml without newlines returns error when caught' > # at t/10_units/05_filters/51_reference_die.t line 50. > # Looks like you failed 2 tests of 5. > t/10_units/05_filters/51_reference_die.t ........... > Dubious, test returned 2 (wstat 512, 0x200) > Failed 2/5 subtests > > This might be the same issue like in > https://github.com/PerlDancer/Dancer/issues/1107
On 2015-04-20 19:08:17, SREZIC wrote: Show quoted text
> POE's test suite fails with a fresh perl 5.21.11: > > # Failed test 'yaml without newlines dies when allowed' > # at t/10_units/05_filters/51_reference_die.t line 45. > > # Failed test 'yaml without newlines returns error when caught' > # at t/10_units/05_filters/51_reference_die.t line 50. > # Looks like you failed 2 tests of 5. > t/10_units/05_filters/51_reference_die.t ........... > Dubious, test returned 2 (wstat 512, 0x200) > Failed 2/5 subtests > > This might be the same issue like in > https://github.com/PerlDancer/Dancer/issues/1107
A possible patch: https://cpan.metacpan.org/authors/id/S/SR/SREZIC/patches/POE-1.366-RT103842.patch
Thank you for the report. The patch looks good, so I've applied it. It will be in the next release. I hope to have it out today. The failing test isn't so much a test of YAML as it is of POE::Filter::Reference handling YAML throwing an exception on certain input. The test description may be overly specific, but I prefer detail.