Skip Menu |

This queue is for tickets about the XML-Feed CPAN distribution.

Report information
The Basics
Id: 103405
Status: resolved
Priority: 0/
Queue: XML-Feed

People
Owner: ether [...] cpan.org
Requestors: genehack [...] genehack.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.55



Subject: Atom feed dates are invalid...
Date: Wed, 8 Apr 2015 22:06:54 -0700
To: bug-XML-Feed [...] rt.cpan.org
From: John SJ Anderson <genehack [...] genehack.org>
...and the handling of the 'issued' and 'modified' attributes in Entry objects in general seems sub-optimal (you require a DateTime object to be provided to set the value, which is converted to a string, which is converted back to a DateTime object upon being read?) The W3C validator has this to say about the dates: This feed does not validate. - line 14 <http://validator.w3.org/feed/check.cgi?url=http%3A%2F%2Fgenehack.net%2Fatom.xml#l14>, column 32: updated must be an RFC-3339 date-time: 2015-03-13T00:00:00 (20 occurrences) [help <http://validator.w3.org/feed/docs/error/InvalidRFC3339Date.html>] <updated>2015-03-13T00:00:00</updated> This is because an RFC-3339 date-time is required to either have an appended time zone offset (e.g., -0500, +0200) *or* is required to use an appended 'Z' to show UTC. There should be a 'Z' on the end of the date-time string above. I'm willing to provide a patch to fix this but I thought I'd check to see if this module is still being maintained? Is there interest in patching this? thanks, john.
On 2015-04-08 22:07:15, genehack@genehack.org wrote: Show quoted text
> I'm willing to provide a patch to fix this but I thought I'd check to > see > if this module is still being maintained? Is there interest in > patching > this?
sure, patches welcome! :D
On Thu Apr 09 21:43:23 2015, ETHER wrote: Show quoted text
> sure, patches welcome! :D
Looking at this further, if I provide a DT that has a 'time_zone' attribute set, I get a valid W3CDTF date out. I don't get the design around the way the datetimes are being stored and formatted, so it's probably better if I don't mess with it...