Bug #103121 for Data-Validate-Domain: Incorrectly validates non 0-9 digits

Wed Mar 25 15:24:50 2015 MARKF [...] cpan.org - Ticket created

Subject:

Incorrectly validates non 0-9 digits

perl -E 'use Data::Validate::Domain; say "broken" if is_hostname("abc\x{0660}.whatever")' broken There's a bug in the is_domain_label function - it should be using [0-9] in the regexp not \d to avoid matching (and approving) characters like ARABIC-INDIC DIGIT ZERO

Thu Mar 26 11:29:33 2015 DROLSKY [...] cpan.org - Correspondence added

On Wed Mar 25 15:24:50 2015, MARKF wrote: Show quoted text

> perl -E 'use Data::Validate::Domain; say "broken" if > is_hostname("abc\x{0660}.whatever")' > broken > > There's a bug in the is_domain_label function - it should be using [0- > 9] in the regexp not \d to avoid matching (and approving) characters > like ARABIC-INDIC DIGIT ZERO

Neil, I'd be happy to fix this if you wanted to give me comaint on this module.

Thu Mar 26 11:29:34 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Apr 24 22:34:32 2015 neil [...] neely.cx - Correspondence added

On Thu Mar 26 11:29:33 2015, DROLSKY wrote: Show quoted text

> On Wed Mar 25 15:24:50 2015, MARKF wrote:

> > perl -E 'use Data::Validate::Domain; say "broken" if > > is_hostname("abc\x{0660}.whatever")' > > broken > > > > There's a bug in the is_domain_label function - it should be using > > [0- > > 9] in the regexp not \d to avoid matching (and approving) characters > > like ARABIC-INDIC DIGIT ZERO

> > Neil, I'd be happy to fix this if you wanted to give me comaint on > this module.

Thanks Dave! I've added you as a Comaint for this module. I've been a slacker maintainer on these for too long...

Wed Apr 29 12:13:32 2015 DROLSKY [...] cpan.org - Correspondence added

On Fri Apr 24 22:34:32 2015, NEELY wrote: Show quoted text

> On Thu Mar 26 11:29:33 2015, DROLSKY wrote:

> > On Wed Mar 25 15:24:50 2015, MARKF wrote:

> > > perl -E 'use Data::Validate::Domain; say "broken" if > > > is_hostname("abc\x{0660}.whatever")' > > > broken > > > > > > There's a bug in the is_domain_label function - it should be using > > > [0- > > > 9] in the regexp not \d to avoid matching (and approving) characters > > > like ARABIC-INDIC DIGIT ZERO

> > > > Neil, I'd be happy to fix this if you wanted to give me comaint on > > this module.

> > > Thanks Dave! I've added you as a Comaint for this module. > > I've been a slacker maintainer on these for too long...

Doh, I totally missed this email! For the GH repo, do you want to give me access? Ideally, you'd transfer it (and Data-Validate-IP) to the autarch-code organization. That way you and I can share admin access to the repo, so I can do things like set up Travis-CI integration. Thanks, -dave

Thu Apr 30 12:52:09 2015 neil [...] neely.cx - Correspondence added

Subject:	Re: [rt.cpan.org #103121] Incorrectly validates non 0-9 digits
Date:	Thu, 30 Apr 2015 10:51:41 -0600
To:	bug-Data-Validate-Domain [...] rt.cpan.org
From:	Neil Neely <neil [...] neely.cx>

I setup the GH collab, I explored trying to transfer it, but it wants me to be an admin of where it is transferring to first (or I am doing it wrong, which is entirely possible). I'm definitely on board with the idea, CI servers are awesome (I use Jenkins at work, but similar idea). Thanks. On Wed, Apr 29, 2015 at 10:13 AM, Dave Rolsky via RT < bug-Data-Validate-Domain@rt.cpan.org> wrote: Show quoted text

> Queue: Data-Validate-Domain > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=103121 > > > On Fri Apr 24 22:34:32 2015, NEELY wrote:

> > On Thu Mar 26 11:29:33 2015, DROLSKY wrote:

> > > On Wed Mar 25 15:24:50 2015, MARKF wrote:

> > > > perl -E 'use Data::Validate::Domain; say "broken" if > > > > is_hostname("abc\x{0660}.whatever")' > > > > broken > > > > > > > > There's a bug in the is_domain_label function - it should be using > > > > [0- > > > > 9] in the regexp not \d to avoid matching (and approving) characters > > > > like ARABIC-INDIC DIGIT ZERO

> > > > > > Neil, I'd be happy to fix this if you wanted to give me comaint on > > > this module.

> > > > > > Thanks Dave! I've added you as a Comaint for this module. > > > > I've been a slacker maintainer on these for too long...

> > Doh, I totally missed this email! > > For the GH repo, do you want to give me access? Ideally, you'd transfer it > (and Data-Validate-IP) to the autarch-code organization. That way you and I > can share admin access to the repo, so I can do things like set up > Travis-CI integration. > > Thanks, > > -dave >

-- Neil Neely

Thu Apr 30 12:56:40 2015 DROLSKY [...] cpan.org - Correspondence added

On Thu Apr 30 12:52:09 2015, NEELY wrote: Show quoted text

> I setup the GH collab, I explored trying to transfer it, but it wants > me to > be an admin of where it is transferring to first (or I am doing it > wrong, > which is entirely possible). I'm definitely on board with the idea, > CI > servers are awesome (I use Jenkins at work, but similar idea).

I invited you to a new team in the autarch-code organization. Once you transfer the repos I can make us both admins of said repos. Thanks, -dave