Bug #103019 for Astro-SpaceTrack: Sublimit set on since

Mon Mar 23 00:51:48 2015 vidar [...] ksat.no - Ticket created

Subject:	Sublimit set on since_file queries
Date:	Mon, 23 Mar 2015 05:51:32 +0100
To:	<bug-Astro-SpaceTrack [...] rt.cpan.org>
From:	Vidar Tyldum <vidar [...] ksat.no>

Hi Tom, If since_file is set and you do a basic retreive() on multiple OIDs the API will only return 1 result. It seems to happen because of the way $rest{sublimit} is set in the if().. in line 2554. To overcome this I simply added a delete of that hash key into the block on line 2567. I don't think that breaks any other intentions in the code: if ( $opt->{since_file} ) { $rest{FILE} = ">$opt->{since_file}"; $rest{class} = 'tle'; delete $rest{sublimit}; } I edited in place, so I have no diff. Thanks for (another) great module. -- Best regards, Vidar Tyldum Lead Software Engineer, Kongsberg Satellite Services AS [Office: +47 77 60 02 74] [PGP : 0xAC85F5B9] [TNOC: +47 77 60 02 68] [Email: vidar@ksat.no]

Download signature.asc
application/pgp-signature 819b

Message body not shown because it is not plain text.

Mon Mar 23 09:28:40 2015 wyant [...] cpan.org - Correspondence added

Thank you very much for reporting this problem, and your diligence in working out a solution. Without you and people like you this would be a much worse module. Unfortunately I am not right now in a position to publish a fix, but I should be able to get a development release out by this weekend. I will update the RT ticket when I have done so.

Mon Mar 23 09:28:40 2015 The RT System itself - Status changed from 'new' to 'open'

Sun Mar 29 15:28:00 2015 wyant [...] cpan.org - Correspondence added

Noe that I have had a chance to look at the problem I am even more appreciative of the effort you put into running this to earth. Thank you very much. I have just sent Astro-SpaceTrack version 0.090_01 to PAUSE. I am deleting the {sublimit} key in a different place, because once I figured out that the problem was that '/sublimit/1' was leaking into the REST query I found other cases where it caused the same problem (e.g. "search_oid( { status => 'onorbit' }, 25544, 25546 );" or some such). I also added a test of the query generated by the retrieve() method with your patch installed, and the code actually published passes (n=1!). So I hope your use case still works the way you want it to.

Sun Mar 29 15:28:02 2015 wyant [...] cpan.org - Status changed from 'open' to 'patched'

Wed Apr 01 12:57:41 2015 wyant [...] cpan.org - Correspondence added

Version 0.090_02 just went to PAUSE. The reason for this release is that, after further thought, I came to the completely obvious conclusion that, when building a REST query from options, it was smarter to only put something in the query if it was needed (0.090_02) versus ensuring it was removed if it was not needed (0.090_01). Release 0.090_02 is intended to build the same queries as 0.090_01, but of course I only know this for the tests in 0.090_01's t/spacetrack_queries.t (which 0.090 fails).

Thu Nov 30 11:14:58 2017 wyant [...] cpan.org - Status changed from 'patched' to 'resolved'

Thu Nov 30 11:14:59 2017 wyant [...] cpan.org - Fixed in 0.091 added

Bug #103019 for Astro-SpaceTrack: Sublimit set on since_file queries

Preferred bug tracker