Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-MakeMaker-Awesome CPAN distribution.

Report information
The Basics
Id: 102947
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-MakeMaker-Awesome

People
Owner: Nobody in particular
Requestors: calid1984 [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Filter MakeMaker by default?
Date: Sat, 21 Mar 2015 19:28:53 -0500
To: bug-Dist-Zilla-Plugin-MakeMaker-Awesome [...] rt.cpan.org
From: Dylan Cali <calid1984 [...] gmail.com>
Is there anyway for MakeMaker::Awesome to detect and automatically filter the stock MakeMaker plugin? I quite frequently forget to add the @Filter boiler and get the "attempt to add Makefile.PL multiple times" error. This isn't a big deal, but it seems common enough that it would be nice if by using MakeMaker::Awesome I also automatically filter MakeMaker, if loaded. That is, without exception, what is meant by use MakeMaker::Awesome (since the two plugins are mutually exclusive), so if MakeMaker::Awesome obviated the need for me to always add this boiler plate that would be... awesome :) Thanks!
On 2015-03-21 17:29:03, calid wrote: Show quoted text
> Is there anyway for MakeMaker::Awesome to detect and automatically > filter the stock MakeMaker plugin? I quite frequently forget to add > the @Filter boiler and get the "attempt to add Makefile.PL multiple > times" error. > > This isn't a big deal, but it seems common enough that it would be > nice if by using MakeMaker::Awesome I also automatically filter > MakeMaker, if loaded. That is, without exception, what is meant by > use MakeMaker::Awesome (since the two plugins are mutually exclusive), > so if MakeMaker::Awesome obviated the need for me to always add this > boiler plate that would be... awesome :) > > Thanks!
It would be pretty difficult to neuter another plugin at arm's length from doing anything, without doing something like monkeypatching the other plugin or ripping it out of the zilla object. Those options both sound.. unawesome. I shall ponder!
Subject: Re: [rt.cpan.org #102947] Filter MakeMaker by default?
Date: Sat, 21 Mar 2015 21:46:30 -0500
To: bug-Dist-Zilla-Plugin-MakeMaker-Awesome [...] rt.cpan.org
From: Dylan Cali <calid1984 [...] gmail.com>
Thanks Karen, let me know what you decide after pondering. In terms of "ripping it out of the zilla object," I think this is one of the few situations where that is okay, since again the two plugins are impossible to load together anyways. If a user adds MakerMaker::Awesome to their dist.ini they probably always mean to use it in favor of the stock plugin. But perhaps instead of silently overriding it the nicer way is to at least print a warning it's being overridden? On Sat, Mar 21, 2015 at 9:34 PM, Karen Etheridge via RT <bug-Dist-Zilla-Plugin-MakeMaker-Awesome@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=102947 > > > On 2015-03-21 17:29:03, calid wrote:
>> Is there anyway for MakeMaker::Awesome to detect and automatically >> filter the stock MakeMaker plugin? I quite frequently forget to add >> the @Filter boiler and get the "attempt to add Makefile.PL multiple >> times" error. >> >> This isn't a big deal, but it seems common enough that it would be >> nice if by using MakeMaker::Awesome I also automatically filter >> MakeMaker, if loaded. That is, without exception, what is meant by >> use MakeMaker::Awesome (since the two plugins are mutually exclusive), >> so if MakeMaker::Awesome obviated the need for me to always add this >> boiler plate that would be... awesome :) >> >> Thanks!
> > It would be pretty difficult to neuter another plugin at arm's length from doing anything, without doing something like monkeypatching the other plugin or ripping it out of the zilla object. Those options both sound.. unawesome. > > I shall ponder! >
On 2015-03-21 19:46:39, calid wrote: Show quoted text
> But perhaps instead of silently overriding it the nicer way is to at > least print a warning it's being overridden?
As of version 0.46, this plugin now dies with a helpful message if it is used in tandem with [MakeMaker]. I think this speaks to the spirit of your original problem?