Bug #102838 for parent: t/parent-pmc.t has DOS EOLs so cannot be pulled into bleadperl

Tue Mar 17 18:27:14 2015 shay [...] cpan.org - Ticket created

Subject:

t/parent-pmc.t has DOS EOLs so cannot be pulled into bleadperl

In the course of updating CPAN modules in bleadperl for the impending release of 5.21.10 I was about to pull in parent-0.231 (just so that we're in sync with the latest CPAN release; I realize there are no actual code changes in the .pm file itself), but I noticed that t/parent-pmc.t has DOS EOLs, which we do not have in bleadperl. That is the only file in parent-0.231 with DOS EOLs. Please could you switch it to UNIX EOLs like all the other files whenever you next make a release? (It isn't essential for 5.21.10, but the deadline is Friday 20th March if you want to see it in that release.) Thanks, Steve PS. I would have sent a pull request on GitHub, but when I forked your repo and looked inside my local clone I found that the file has UNIX EOLs anyway! I'm not sure what happened there. Maybe some EOL conversion in Git? Or maybe a glitch in whatever process you used to create your release tarball?

Wed Mar 18 02:33:40 2015 SREZIC [...] cpan.org - Correspondence added

On 2015-03-17 18:27:14, SHAY wrote: Show quoted text

> In the course of updating CPAN modules in bleadperl for the impending > release of 5.21.10 I was about to pull in parent-0.231 (just so that > we're in sync with the latest CPAN release; I realize there are no > actual code changes in the .pm file itself), but I noticed that > t/parent-pmc.t has DOS EOLs, which we do not have in bleadperl. > > That is the only file in parent-0.231 with DOS EOLs. Please could you > switch it to UNIX EOLs like all the other files whenever you next make > a release? (It isn't essential for 5.21.10, but the deadline is Friday > 20th March if you want to see it in that release.) > > Thanks, > Steve > > PS. I would have sent a pull request on GitHub, but when I forked your > repo and looked inside my local clone I found that the file has UNIX > EOLs anyway! I'm not sure what happened there. Maybe some EOL > conversion in Git? Or maybe a glitch in whatever process you used to > create your release tarball?

See https://github.com/Corion/parent/commit/a9ac26832cbc2ed7ecc5c77a0142f5a8f37820ec

Wed Mar 18 02:33:41 2015 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 19 15:32:31 2015 corion [...] cpan.org - Correspondence added

Thanks! That's what I get for not putting my 99-* sanity tests into the distribution :) 0.232 is on its way to CPAN - if you still find time before the 5.21.10 release, that'd be great, but it's no real need, as parent.pm is unchanged. -max

Thu Mar 19 15:32:39 2015 corion [...] cpan.org - Status changed from 'open' to 'resolved'