Skip Menu |

This queue is for tickets about the Net-Amazon-EC2 CPAN distribution.

Report information
The Basics
Id: 102787
Status: resolved
Priority: 0/
Queue: Net-Amazon-EC2

People
Owner: Nobody in particular
Requestors: jens-uwe.schluessler [...] tu-dresden.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Feature request (tagsets in describe_image describe_snapshot)
Date: Sun, 15 Mar 2015 17:06:06 +0100
To: <bug-Net-Amazon-EC2 [...] rt.cpan.org>
From: Jens-Uwe Schlüßler <jens-uwe.schluessler [...] tu-dresden.de>
Dear Amazon-EC2 maintainer, can you please check if “tagsets” may be supported also for DescribeSnapshots and DescribeImages ? A trial implementation would require changes in these 3 files (modules): ./lib/site_perl/5.18.0/Net/Amazon/EC2.pm ./lib/site_perl/5.18.0/Net/Amazon/EC2/Snapshot.pm ./lib/site_perl/5.18.0/Net/Amazon/EC2/DescribeImagesResponse.pm Many thanks, Jens-Uwe Detailed diff (based on Module Version: 0.29 Source ): diff ./lib/Net/Amazon/EC2/DescribeImagesResponse_patch.pm ./lib/Net/Amazon/EC2/DescribeImagesResponse.pm 128,130d127 < #RI < has 'tag_set' => ( is => 'ro', isa => 'Maybe[ArrayRef[Net::Amazon::EC2::TagSet]]', required => 0 ); < #RI diff ./lib/Net/Amazon/EC2/Snapshot_patch.pm ./lib/Net/Amazon/EC2/Snapshot.pm 65,67d64 < #RI < has 'tag_set' => ( is => 'ro', isa => 'Maybe[ArrayRef[Net::Amazon::EC2::TagSet]]', required => 0 ); < #RI diff ./lib/Net/Amazon/EC2_patch.pm ./lib/Net/Amazon/EC2.pm 1838,1850d1837 < ##RI < my $tag_sets; < foreach my $tag_arr (@{$item->{tagSet}{item}}) { < if ( ref $tag_arr->{value} eq "HASH" ) { < $tag_arr->{value} = ""; < } < my $tag = Net::Amazon::EC2::TagSet->new( < key => $tag_arr->{key}, < value => $tag_arr->{value}, < ); < push @$tag_sets, $tag; < } < ##RI 1870,1872d1856 < ##RI < tag_set => $tag_sets, < ##RI 2890,2902c2874 < ##RI < my $tag_sets; < foreach my $tag_arr (@{$snap->{tagSet}{item}}) { < if ( ref $tag_arr->{value} eq "HASH" ) { < $tag_arr->{value} = ""; < } < my $tag = Net::Amazon::EC2::TagSet->new( < key => $tag_arr->{key}, < value => $tag_arr->{value}, < ); < push @$tag_sets, $tag; < } < ##RI --- Show quoted text
>
2913,2915d2884 < ##RI < tag_set => $tag_sets, < ##RI -- Jens-Uwe Schlüßler Show quoted text
_______________________________________________________________ Technische Universität Dresden Institut Grundlagen der ET/Elektronik ( IEE ) Stiftungsprofessur Hochparallele VLSI-Systeme und Neuromikroelektronik (Prof. Schüffny) 01062 DRESDEN Phone (++49 351) 463 33602 GERMANY Fax (++49 351) 463 37794 EMail Jens-Uwe.Schluessler@tu-dresden.de WWW http://hpsn.et.tu-dresden.de
_______________________________________________________________

Message body is not shown because it is too large.

Download smime.p7s
application/pkcs7-signature 5.9k

Message body not shown because it is not plain text.

On Sun Mar 15 12:06:28 2015, jens-uwe.schluessler@tu-dresden.de wrote: Show quoted text
> can you please check if “tagsets” may be supported also for > DescribeSnapshots and DescribeImages ? > > A trial implementation would require changes in these 3 files (modules): > ./lib/site_perl/5.18.0/Net/Amazon/EC2.pm > ./lib/site_perl/5.18.0/Net/Amazon/EC2/Snapshot.pm > ./lib/site_perl/5.18.0/Net/Amazon/EC2/DescribeImagesResponse.pm
Thanks for the patches. Would it be possible for you to submit them as email attachments using diff -u? Or you can visit the RT ticket and attach them there manually. Thanks. That would really help me get this integrated as quickly as possible. Mark
Subject: AW: [rt.cpan.org #102787] Feature request (tagsets in describe_image describe_snapshot)
Date: Sun, 15 Mar 2015 19:45:05 +0100
To: <bug-Net-Amazon-EC2 [...] rt.cpan.org>
From: Jens-Uwe Schlüßler <jens-uwe.schluessler [...] tu-dresden.de>
Hi Mark, thanks for the fast response. attached the "diff -u" files (I still nor have an RT CPAN account). Jens-Uwe Show quoted text
-----Ursprüngliche Nachricht----- Von: Mark Allen via RT [mailto:bug-Net-Amazon-EC2@rt.cpan.org] Gesendet: Sonntag, 15. März 2015 19:22 An: jens-uwe.schluessler@tu-dresden.de Betreff: [rt.cpan.org #102787] Feature request (tagsets in describe_image describe_snapshot) <URL: https://rt.cpan.org/Ticket/Display.html?id=102787 > On Sun Mar 15 12:06:28 2015, jens-uwe.schluessler@tu-dresden.de wrote:
> can you please check if “tagsets” may be supported also for > DescribeSnapshots and DescribeImages ? > > A trial implementation would require changes in these 3 files (modules): > ./lib/site_perl/5.18.0/Net/Amazon/EC2.pm > ./lib/site_perl/5.18.0/Net/Amazon/EC2/Snapshot.pm > ./lib/site_perl/5.18.0/Net/Amazon/EC2/DescribeImagesResponse.pm
Thanks for the patches. Would it be possible for you to submit them as email attachments using diff -u? Or you can visit the RT ticket and attach them there manually. Thanks. That would really help me get this integrated as quickly as possible. Mark

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Message body is not shown because sender requested not to inline it.

Download smime.p7s
application/pkcs7-signature 5.9k

Message body not shown because it is not plain text.

On Sun Mar 15 14:45:20 2015, jens-uwe.schluessler@tu-dresden.de wrote: Show quoted text
> Hi Mark, > thanks for the fast response. > attached the "diff -u" files (I still nor have an RT CPAN account).
Applied as 24e0fb4 - I am releasing 0.30 today which contains these patches. Thanks.