Skip Menu |

This queue is for tickets about the Encode-Locale CPAN distribution.

Report information
The Basics
Id: 102738
Status: resolved
Priority: 0/
Queue: Encode-Locale

People
Owner: Nobody in particular
Requestors: tsibley [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.04
Fixed in: (no value)



Subject: [PATCH] Conditionalize Win32::Console recommendation
Otherwise CPAN clients configured to follow recommended dependencies will try to install Win32::Console even if they're not running on Windows. Pull request: https://github.com/gisle/encode-locale/pull/12 Or attached as a git format-patch.
Subject: Conditionalize-Win32-Console-recommendation.patch
From 9ca4fbe4c26c18cee8b7c27977c7e74e23ac623f Mon Sep 17 00:00:00 2001 From: Thomas Sibley <tsibley@cpan.org> Date: Thu, 12 Mar 2015 16:46:05 -0700 Subject: [PATCH] Conditionalize the Win32::Console recommendation Otherwise CPAN clients configured to follow recommended dependencies will try to install Win32::Console even if they're not running on Windows. --- Makefile.PL | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index a518a67..8489295 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -18,7 +18,9 @@ WriteMakefile( }, recommends => { 'I18N::Langinfo' => 0, - 'Win32::Console' => 0, + ($^O eq 'MSWin32' + ? ('Win32::Console' => 0) + : ()), }, }, TEST_REQUIRES => {
On 2015-03-12 16:50:54, TSIBLEY wrote: Show quoted text
> Otherwise CPAN clients configured to follow recommended dependencies > will try to install Win32::Console even if they're not running on > Windows. > > Pull request: https://github.com/gisle/encode-locale/pull/12 > > Or attached as a git format-patch.
Take care when releasing - if releasing from windows, the recommendation will still be in META.json. You also need to ensure that dynamic_config is set to true in metadata.
Subject: Re: [rt.cpan.org #102738] [PATCH] Conditionalize Win32::Console recommendation
Date: Thu, 12 Mar 2015 22:23:03 -0700
To: bug-Encode-Locale [...] rt.cpan.org
From: Thomas Sibley <tsibley [...] cpan.org>
On 03/12/2015 05:12 PM, Karen Etheridge via RT wrote: Show quoted text
> Take care when releasing - if releasing from windows, the recommendation will still be in META.json.
True. I guess the conditional could also hinge on some variable set when releasing, though I don't know what that would be off the top of my head. Show quoted text
> You also need to ensure that dynamic_config is set to true in metadata.
I checked this and it seems to default on for EUMM, at least when I ran make distmeta.
The patch was applied to 1.05 that I just uploaded.  The dynamic_config part seem like too much hassle, so I ignored it for now.  I'm not releasing from Windows, which means that this recommendation is now gone from the static META files.
Thanks!