Bug #102732 for Test-Unit: Can't use 'defined(@array)'

Thu Mar 12 15:10:31 2015 SREZIC [...] cpan.org - Ticket created

Subject:

Can't use 'defined(@array)'

With newest perls this is now a hard error, not a warning anymore: PERL_DL_NONLAZY=1 "/bbbike/perl-5.21.9/bin/perl5.21.9" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at /tmpfs/.cpan-build/Test-Unit-0.25-ABxy7S/blib/lib/Test/Unit/TestCase.pm line 106. Compilation failed in require at /tmpfs/.cpan-build/Test-Unit-0.25-ABxy7S/blib/lib/Test/Unit/TestSuite.pm line 15. ...

Thu May 28 03:31:10 2015 NGLENN [...] cpan.org - Correspondence added

Line 106 of TestCase.pm needs to be changed to this: if (@{"$class\::TESTS"}) { This should be a very quick fix and will probably eliminate a large number of test failures. Currently this blocks the installation of another module I'd like to use. Matthew, do you have time to do a release of this?

Thu May 28 03:31:10 2015 The RT System itself - Status changed from 'new' to 'open'

Mon Apr 03 13:01:01 2017 jkeenan [...] cpan.org - Correspondence added

On Thu May 28 03:31:10 2015, NGLENN wrote: Show quoted text

> Line 106 of TestCase.pm needs to be changed to this: > > if (@{"$class\::TESTS"}) { > > This should be a very quick fix and will probably eliminate a large > number of test failures. Currently this blocks the installation of > another module I'd like to use. > > Matthew, do you have time to do a release of this?

I am attaching that correction in patch form (drawn against the 2011 dev release). MCAST, if you can apply it and issue a new CPAN release, it will bring Test-Unit into perl-5.26.0-readiness. If you are unable to continue to maintain this distribution, could you designate a COMAINT? Thank you very much. Jim Keenan

Subject:

Test-Unit.20170403.diff

--- ./lib/Test/Unit/TestCase.pm.orig 2017-04-03 12:55:34.085383089 -0400 +++ ./lib/Test/Unit/TestCase.pm 2017-04-03 12:56:27.162086875 -0400 @@ -106,7 +106,7 @@ my $class = ref($_[0]) || $_[0]; my @tests = (); no strict 'refs'; - if (defined(@{"$class\::TESTS"})) { + if (@{"$class\::TESTS"}) { push @tests, @{"$class\::TESTS"}; } else {

Thu Jul 05 07:52:02 2018 domq [...] cpan.org - Correspondence added

Today I pinged the (co-)maintainers aspiers@cpan.org, mcast@cpan.org (and clemburg@cpan.org, but that one bounced) to roll out a new release containing JKEENAN's fix. My copy of that fix is at GitHub (https://github.com/domq/Test-Unit). To test it out: 1. git clone https://github.com/domq/Test-Unit.git 2. perl -i -pe 's/\.git/\.gitz/' inc/GetVersion.pm 3. perl Makefile.PL && make test