Skip Menu |

This queue is for tickets about the Net-FTPSSL CPAN distribution.

Report information
The Basics
Id: 102680
Status: resolved
Priority: 0/
Queue: Net-FTPSSL

People
Owner: Nobody in particular
Requestors: BBYRD [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.20
  • 0.21
  • 0.22
  • 0.23
  • 0.24
  • 0.25
  • 0.26
Fixed in: 0.27



Subject: xput/xtransfer doesn't honor OverrideHELP
Setting OverrideHELP doesn't do anything to xput/xtransfer's $help checks. This is because it's checking the $help hash directly, instead of using $self->supported. Either that or _help should populate the hash with every known command if OverrideHELP was set to 1. Furthermore, the OverrideHELP check in new uses defined, so OverrideHELP => 0 doesn't work too well.
Hello & Thank You for using my module. I've looked at the code & you are correct about the problems with the "help" checks in the 2 'x' functions. They were performed incorrectly with regard to using the OverrideHELP=>1 option after it was introduced to my module in v0.16. This will be corrected in the next release of my module. But setting OverrideHELP=>0 in new() doesn't cause any problems. It works as desired. So there is no bug there. After it's been set, all calls to supported() always returns false as expected. There was just no need for extra logic beyond the "defined" test you mentioned. It just silently morphed into a OverrideHELP=>\@array call, where @array represented an empty array without any members. Curtis On Tue Mar 10 15:21:15 2015, BBYRD wrote: Show quoted text
> Setting OverrideHELP doesn't do anything to xput/xtransfer's $help > checks. This is because it's checking the $help hash directly, > instead of using $self->supported. Either that or _help should > populate the hash with every known command if OverrideHELP was set to > 1. > > Furthermore, the OverrideHELP check in new uses defined, so > OverrideHELP => 0 doesn't work too well.
This problem has been fixed and a new release has been uploaded to CPAN. It should be available later today. Enjoy! Curtis On Tue Mar 17 14:11:53 2015, CLEACH wrote: Show quoted text
> Hello & Thank You for using my module. > > I've looked at the code & you are correct about the problems with the > "help" checks in the 2 'x' functions. They were performed incorrectly > with regard to using the OverrideHELP=>1 option after it was > introduced to my module in v0.16. This will be corrected in the next > release of my module. > > But setting OverrideHELP=>0 in new() doesn't cause any problems. It > works as desired. So there is no bug there. After it's been set, all > calls to supported() always returns false as expected. There was just > no need for extra logic beyond the "defined" test you mentioned. It > just silently morphed into a OverrideHELP=>\@array call, where @array > represented an empty array without any members. > > Curtis > > On Tue Mar 10 15:21:15 2015, BBYRD wrote:
> > Setting OverrideHELP doesn't do anything to xput/xtransfer's $help > > checks. This is because it's checking the $help hash directly, > > instead of using $self->supported. Either that or _help should > > populate the hash with every known command if OverrideHELP was set to > > 1. > > > > Furthermore, the OverrideHELP check in new uses defined, so > > OverrideHELP => 0 doesn't work too well.