Skip Menu |

This queue is for tickets about the Archive-Tar-Wrapper CPAN distribution.

Report information
The Basics
Id: 102645
Status: resolved
Priority: 0/
Queue: Archive-Tar-Wrapper
People
Owner: arfreitas [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.22
Fixed in: (no value)

History Show all quoted text
  Mon Mar 09 02:25:54 2015 SREZIC [...] cpan.org - Ticket created
Subject: Tests fail on FreeBSD systems (non-gnu tar?)
See subject.
  Mon Mar 09 02:28:07 2015 SREZIC [...] cpan.org - Correspondence added
On 2015-03-09 02:25:54, SREZIC wrote: Show quoted text
> See subject.
It seems that skip() logic needs to be fixed. See attached patch.
Subject: Archive-Tar-Wrapper-0.22-RT102645.patch
From 0085c16ed066b69e25082f8c48d9703cdd4c9bff Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Mon, 9 Mar 2015 07:25:05 +0100 Subject: [PATCH] fix skip for non-gnu tar [RT #102645] --- t/001Basic.t | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/t/001Basic.t b/t/001Basic.t index e97e7cb..3f822c5 100644 --- a/t/001Basic.t +++ b/t/001Basic.t @@ -131,12 +131,13 @@ SKIP: { $f1 = $a6->locate("bar/bar.dat"); ok(defined $f1, "numeric owner works"); +} +SKIP: { # gnu options my $tar = Archive::Tar::Wrapper->new( tar_gnu_write_options => ["--exclude=foo"], ); - skip "Only with gnu tar", 1 unless $tar->is_gnu(); my $file_loc = $tar->locate("001Basic.t"); -- 2.1.2
  Thu Mar 19 02:33:24 2015 bokutin [...] cpan.org - Correspondence added
The same problem has occurred in my environment.
  Thu Mar 19 02:33:24 2015 The RT System itself - Status changed from 'new' to 'open'
  Thu Mar 19 02:33:29 2015 bokutin [...] cpan.org - Fixed in 0.22 added
  Thu Mar 19 02:34:11 2015 bokutin [...] cpan.org - Correspondence added
On 2015-3月-19 木 02:33:24, bokutin wrote: Show quoted text
> The same problem has occurred in my environment.
  Thu Mar 19 02:34:17 2015 bokutin [...] cpan.org - Fixed in 0.22 deleted
  Mon Apr 27 15:21:56 2015 mjgardner [...] cpan.org - Correspondence added
On Mon Mar 09 02:28:07 2015, SREZIC wrote: Show quoted text
> On 2015-03-09 02:25:54, SREZIC wrote:
> > See subject.
> > It seems that skip() logic needs to be fixed. See attached patch.
FWIW I submitted a pull request on GitHub: https://github.com/mschilli/archive-tar-wrapper-perl/pull/7
  Sat Jun 02 12:16:57 2018 arfreitas [...] cpan.org - Correspondence added
Fixed with PR https://github.com/mschilli/archive-tar-wrapper-perl/pull/7
  Sat Jun 02 12:16:58 2018 arfreitas [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Jun 02 12:16:59 2018 arfreitas [...] cpan.org - Taken