On 2015-03-08 03:00:41, MICHIELB wrote:
Show quoted text> I'm not sure if I did something wrong here, but I added your test to
> my module and am now getting smoker failures:
>
> # Distribution files are missing in MANIFEST:
> # _eumm/SMS-Send-Twilio.ppd
> # _eumm/META_new.json
> # _eumm/META_new.yml
>
> # Failed test 'All files are listed in MANIFEST or skipped'
> # at t/distmanifest.t line 7.
> # Looks like you failed 1 test of 4.
>
>
http://www.cpantesters.org/cpan/report/f9a8cfcc-c37b-11e4-b0fb-d9658971dd2f
Your MANIFEST.SKIP contains static entries, but the build artifacts that ExtUtils::MakeMaker produces changes with its version. Put this at the top of your MANIFEST.SKIP:
#!include_default
(and do not commit to git its attempts to expand that to the underlying values), and all will be well.
In ExtUtils::MakeMaker 7.05_*, the new _eumm/ directory started being created. ExtUtils::Manifest (the producer of MANIFEST, and parser of MANIFEST.SKIP) contains _eumm/ in its 'default' list (and in fact EUMM has a self-contained version of ExtUtils::Manifest inside it for private use, so the two cannot ever become out of sync), but your MANIFEST.SKIP in the distribution isn't including that value.
Show quoted text> I do understand it would be best to only run the module when
> RELEASE_TESTING or AUTHOR_TESTING is on.
Yup, and you can see why :D
I'll include a stronger reference in TDM's documentation pointing to EUM's #!include_default syntax. As the new ExtUtils::Manifest gets smoked on more testing systems, I expect to see more issues arising with the new _eumm directory :)
