Bug #102397 for ExtUtils-MakeMaker: non-deterministic order of files

Fri Feb 27 07:23:23 2015 zefram [...] fysh.org - Ticket created

Subject:	non-deterministic order of files
Date:	Fri, 27 Feb 2015 12:23:08 +0000
To:	bug-ExtUtils-MakeMaker [...] rt.cpan.org
From:	Zefram <zefram [...] fysh.org>

In some places ExtUtils-MakeMaker processes files in non-deterministic order, depending on hash order. In order to be able to meaningfully diff installation logs, it would be nice for EU-MM to be deterministic. There was a previous change making some parts deterministic, but it missed other places with the same problem. Attached patch fixes the remaining parts. -zefram

Message body is not shown because sender requested not to inline it.

Fri Feb 27 10:36:39 2015 ETJ [...] cpan.org - Correspondence added 10 min

On Fri Feb 27 07:23:23 2015, zefram@fysh.org wrote: Show quoted text

> In some places ExtUtils-MakeMaker processes files in non-deterministic > order, depending on hash order. In order to be able to meaningfully > diff installation logs, it would be nice for EU-MM to be deterministic. > There was a previous change making some parts deterministic, but it > missed other places with the same problem. Attached patch fixes the > remaining parts. > > -zefram

This looks like it's not against the latest dev version of EUMM. Please could you instead make a pull request against https://github.com/Perl-Toolchain-Gang/ExtUtils-MakeMaker ? Also, some of these changes look like they wouldn't actually affect even installation logs, as though you just blindly went through all uses of keys/values/each. Finally, one of the files you changed, .../Locale.pm, is effectively a bundle of Encode::Locale. You'd want to make a PR against that and get it accepted because I don't want to just change the EUMM version alone.

Fri Feb 27 10:36:39 2015 The RT System itself - Status changed from 'new' to 'open'

Fri Feb 27 10:36:40 2015 ETJ [...] cpan.org - Taken

Fri Feb 27 12:03:53 2015 zefram [...] fysh.org - Correspondence added

Subject:	Re: [rt.cpan.org #102397] non-deterministic order of files
Date:	Fri, 27 Feb 2015 17:03:39 +0000
To:	Ed J via RT <bug-ExtUtils-MakeMaker [...] rt.cpan.org>
From:	Zefram <zefram [...] fysh.org>

Ed J via RT wrote: Show quoted text

>This looks like it's not against the latest dev version of >EUMM. Please could you instead make a pull request

No, I can't make a pull request, because I don't drink the github kool-aid. I could make a patch based on the current version from the git repo, though. My patch was based on ExtUtils-MakeMaker-7.04.tar.gz from CPAN. Show quoted text

>Also, some of these changes look like they wouldn't actually affect >even installation logs, as though you just blindly went through all uses >of keys/values/each.

It was not a blind process. I did examine each use of those operators, and a couple of other things, and I added sorting to any that looked like they could affect any output. Not just output that would appear in an installation log by default, but also anything affecting the Makefile (some of which is hidden by $(NOECHO) but is then visible under "make -n") and debugging trace output. I did not add sorting to instances of these operators that are clearly order-independent, such as for hash merging. Show quoted text

>Finally, one of the files you changed, .../Locale.pm, is effectively >a bundle of Encode::Locale.

Ah, OK. Redirect accepted on that file. -zefram

Thu Apr 21 10:09:12 2016 BINGOS [...] cpan.org - Correspondence added

This was fixed in the repo last year. 7.12 is out now. Many thanks.

Thu Apr 21 10:09:20 2016 BINGOS [...] cpan.org - Status changed from 'open' to 'resolved'