Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Git CPAN distribution.

Report information
The Basics
Id: 102287
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-Git

People
Owner: Nobody in particular
Requestors: calid1984 [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 2.030



Subject: tag-signed.t and tag.t fail if git color.ui = always
Date: Sun, 22 Feb 2015 15:08:06 -0600
To: bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From: Dylan Cali <calid1984 [...] gmail.com>
t/00-compile.t .................. ok t/000-report-git-version.t ...... # git version 2.1.3 t/000-report-git-version.t ...... ok t/000-report-versions-tiny.t .... # # # Generated by Dist::Zilla::Plugin::ReportVersions::Tiny v1.10 # perl: 5.020001 (wanted 5.010) on linux from /home/calid/perl5/perlbrew/perls/perl-5.20.1/bin/perl # # CPAN::Meta::Check => 0.010 (want 0.007) # CPAN::Meta::Requirements => 2.125 (want any version) # Cwd => 3.48 (want any version) # DateTime => 1.18 (want any version) # Devel::SimpleTrace => 0.08 (want any version) # Dist::Zilla => 5.032 (want 4) # Dist::Zilla::File::InMemory => 5.032 (want any version) # Dist::Zilla::Plugin::Config::Git => 0.92 (want any version) # Dist::Zilla::Plugin::GatherDir => 5.032 (want 4.200016) # Dist::Zilla::Role::AfterBuild => 5.032 (want any version) # Dist::Zilla::Role::AfterMint => 5.032 (want any version) # Dist::Zilla::Role::AfterRelease => 5.032 (want any version) # Dist::Zilla::Role::BeforeRelease => 5.032 (want any version) # Dist::Zilla::Role::FilePruner => 5.032 (want any version) # Dist::Zilla::Role::GitConfig => 0.92 (want any version) # Dist::Zilla::Role::PluginBundle => 5.032 (want any version) # Dist::Zilla::Role::Releaser => 5.032 (want any version) # Dist::Zilla::Role::VersionProvider => 5.032 (want any version) # Dist::Zilla::Tester => 5.032 (want any version) # Encode => 2.60 (want any version) # Exporter => 5.71 (want any version) # File::Copy => 2.30 (want any version) # File::Copy::Recursive => 0.38 (want any version) # File::Path => 2.09 (want 2.07) # File::Spec => 3.48 (want any version) # File::Spec::Functions => 3.48 (want any version) # File::Temp => 0.2304 (want any version) # File::Which => 1.09 (want any version) # File::chdir => 0.1010 (want any version) # File::pushd => 1.009 (want any version) # Git::Wrapper => 0.038 (want 0.021) # IO::Handle => 1.35 (want any version) # IPC::Open3 => 1.16 (want any version) # IPC::System::Simple => 1.25 (want any version) # List::AllUtils => 0.09 (want any version) # List::MoreUtils => 0.405 (want any version) # List::Util => 1.38 (want any version) # Log::Dispatchouli => 2.012 (want any version) # Module::Build => 0.4211 (want 0.3601) # Module::Runtime => 0.014 (want any version) # Moose => 2.1403 (want any version) # Moose::Role => 2.1403 (want any version) # Moose::Util::TypeConstraints => 2.1403 (want any version) # MooseX::Has::Sugar => 1.000004 (want any version) # MooseX::Types::Moose => 0.45 (want any version) # MooseX::Types::Path::Tiny => 0.011 (want 0.010) # Path::Tiny => 0.061 (want 0.048) # String::Formatter => 0.102084 (want any version) # Test::DZil => 5.032 (want any version) # Test::Fatal => 0.014 (want 0.006) # Test::More => 1.001014 (want 0.88) # Try::Tiny => 0.22 (want any version) # Version::Next => 0.004 (want any version) # constant => 1.31 (want any version) # lib => 0.63 (want any version) # namespace::autoclean => 0.24 (want 0.09) # strict => 1.08 (want any version) # utf8 => 1.13_01 (want any version) # version => 0.9909 (want 0.80) # warnings => 1.23 (want any version) # # Thanks for using my code. I hope it works for you. # If not, please try and include this output in the bug report. # That will help me reproduce the issue and solve your problem. # t/000-report-versions-tiny.t .... ok t/check.t ....................... ok t/commit-build-custom.t ......... ok t/commit-build-src-as-parent.t .. ok t/commit-build.t ................ ok t/commit-dirtydir.t ............. ok t/commit-message.t .............. ok t/commit-utf8.t ................. ok t/commit-ws.t ................... ok t/commit.t ...................... ok t/gatherdir.t ................... ok t/push-gitconfig.t .............. ok t/push-multi.t .................. ok t/push.t ........................ ok t/release-pod-coverage.t ........ skipped: these tests are for release candidate testing t/release-pod-syntax.t .......... skipped: these tests are for release candidate testing t/repo-dir.t .................... ok t/tag-signed.t .................. 1/8 # Failed test 'Is it a real tag?' # at t/tag-signed.t line 70. # 'tag v1.23 # Tagger: dzp-git test <dzp-git@test> # # v1.23: # # - foo # - bar # - baz # -----BEGIN PGP SIGNATURE----- # Version: GnuPG v2 # # iJwEAAECAAYFAlTqRA4ACgkQ0/khcH2F7USVhwP/UNkqi9jI/Z+WBiBuzCrR9iKl # 0C8kfb46+J3iobSR83CbgeMZgBH/vAG/nHo/Azi5UItSzY3lySn1MrA84nDGFyY2 # TO9K0NZv0Pcg1ImI1yuj0P+xLk0f2zwnSiMBMAZ0heS0cuGHsS9wupg8/EiSMX06 # Zoj+rOV7IDDzrTqPv2M= # =agbK # -----END PGP SIGNATURE----- # # commit 97206ef32e940790ccbf8d7e71d8048d38e091a3 # Author: dzp-git test <dzp-git@test> # # initial commit # # diff --git a/Changes b/Changes # new file mode 100644 # index 0000000..266b6d7 # --- /dev/null # +++ b/Changes # @@ -0,0 +1,6 @@ # +Changes # + # +1.23 2009-11-16 19:15:45 CET # + - foo # + - bar # + - baz # diff --git a/dist.ini b/dist.ini # new file mode 100644 # index 0000000..ebfe176 # --- /dev/null # +++ b/dist.ini # @@ -0,0 +1,14 @@ # +name = Foo # +version = 1.23 # +author = foobar # +license = Perl_5 # +abstract = Test Library # +copyright_holder = foobar # +copyright_year = 2009 # + # +[FakeRelease] # +[MetaConfig] # +[GatherDir] # +[Git::Tag] # +tag_message = v%v:%n%n%c' # doesn't match '(?^m:^tag v1.23)' # Looks like you failed 1 test of 8. t/tag-signed.t .................. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/8 subtests t/tag.t ......................... 1/8 # Failed test 'Is it a real tag?' # at t/tag.t line 59. # 'tag v1.23 # Tagger: dzp-git test <dzp-git@test> # # v1.23: # # - foo # - bar # - baz # # commit 41936f76274ffed32ccf2c58c237f09a8d1c74aa # Author: dzp-git test <dzp-git@test> # # initial commit # # diff --git a/Changes b/Changes # new file mode 100644 # index 0000000..768121a # --- /dev/null # +++ b/Changes # @@ -0,0 +1,9 @@ # +Changes # + # +1.23 2009-11-16 19:15:45 CET # + - foo # + - bar # + - baz # + # +1.00 2008-11-16 19:15:45 CET # + - initial version # diff --git a/dist.ini b/dist.ini # new file mode 100644 # index 0000000..640cb3e # --- /dev/null # +++ b/dist.ini # @@ -0,0 +1,13 @@ # +name = Foo # +version = 1.23 # +author = foobar # +license = Perl_5 # +abstract = Test Library # +copyright_holder = foobar # +copyright_year = 2009 # + # +[FakeRelease] # +[MetaConfig] # +[GatherDir] # +[Git::Tag]' # doesn't match '(?^m:^tag v1.23)' # Failed test 'Includes commit message?' # at t/tag.t line 62. # 'tag v1.23 # Tagger: dzp-git test <dzp-git@test> # # v1.23: # # - foo # - bar # - baz # # commit 41936f76274ffed32ccf2c58c237f09a8d1c74aa # Author: dzp-git test <dzp-git@test> # # initial commit # # diff --git a/Changes b/Changes # new file mode 100644 # index 0000000..768121a # --- /dev/null # +++ b/Changes # @@ -0,0 +1,9 @@ # +Changes # + # +1.23 2009-11-16 19:15:45 CET # + - foo # + - bar # + - baz # + # +1.00 2008-11-16 19:15:45 CET # + - initial version # diff --git a/dist.ini b/dist.ini # new file mode 100644 # index 0000000..640cb3e # --- /dev/null # +++ b/dist.ini # @@ -0,0 +1,13 @@ # +name = Foo # +version = 1.23 # +author = foobar # +license = Perl_5 # +abstract = Test Library # +copyright_holder = foobar # +copyright_year = 2009 # + # +[FakeRelease] # +[MetaConfig] # +[GatherDir] # +[Git::Tag]' # doesn't match '(?^m:^v1.23:\n\n - foo\n - bar\n - baz\n\z)' # Looks like you failed 2 tests of 8. t/tag.t ......................... Dubious, test returned 2 (wstat 512, 0x200) Failed 2/8 subtests t/version-by-branch.t ........... ok t/version-default.t ............. ok t/version-extraction.t .......... ok t/version-regexp.t .............. ok t/zzz-check-breaks.t ............ ok Test Summary Report ------------------- t/tag-signed.t (Wstat: 256 Tests: 8 Failed: 1) Failed test: 4 Non-zero exit status: 1 t/tag.t (Wstat: 512 Tests: 8 Failed: 2) Failed tests: 4, 7 Non-zero exit status: 2 Files=26, Tests=210, 26 wallclock secs ( 0.09 usr 0.12 sys + 16.35 cusr 7.68 csys = 24.24 CPU) Result: FAIL Failed 2/26 test programs. 3/210 subtests failed.d/perl5/perĀalid/perl5/perĀ
How did you set color.ui = always? The test resets HOME to a temporary directory it creates specifically to prevent your global Git config from interfering with the tests. I can reproduce the failure if I change the test to write color.ui = always to its config, but not if I just do "git config --global color.ui always".
Subject: Re: [rt.cpan.org #102287] tag-signed.t and tag.t fail if git color.ui = always
Date: Sun, 22 Feb 2015 17:31:27 -0600
To: bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From: Dylan Cali <calid1984 [...] gmail.com>
It's in my system /etc/gitconfig. In the temporary HOME do you explicitly set color.ui = never? If not, I'm guessing that would fix it. On Sun, Feb 22, 2015 at 4:38 PM, Christopher J. Madsen via RT <bug-Dist-Zilla-Plugin-Git@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=102287 > > > How did you set color.ui = always? The test resets HOME to a temporary directory it creates specifically to prevent your global Git config from interfering with the tests. > > I can reproduce the failure if I change the test to write color.ui = always to its config, but not if I just do "git config --global color.ui always".
Does adding $ENV{GIT_CONFIG_NOSYSTEM} = 1; right after the delete $ENV{$_} for grep /^GIT_/i, keys %ENV; line fix the problem?
Subject: Re: [rt.cpan.org #102287] tag-signed.t and tag.t fail if git color.ui = always
Date: Wed, 25 Feb 2015 07:30:10 -0600
To: bug-Dist-Zilla-Plugin-Git [...] rt.cpan.org
From: Dylan Cali <calid1984 [...] gmail.com>
Yep, that works On Mon, Feb 23, 2015 at 2:40 PM, Christopher J. Madsen via RT <bug-Dist-Zilla-Plugin-Git@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=102287 > > > Does adding > > $ENV{GIT_CONFIG_NOSYSTEM} = 1; > > right after the > > delete $ENV{$_} for grep /^GIT_/i, keys %ENV; > > line fix the problem?
Tests now set GIT_CONFIG_NOSYSTEM